Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: src/crankshaft/hydrogen-instructions.cc

Issue 1728423002: [crankshaft] Remove useless HCallJSFunction instruction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@remove-dynamic-frame-alignment
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen-instructions.cc
diff --git a/src/crankshaft/hydrogen-instructions.cc b/src/crankshaft/hydrogen-instructions.cc
index 328b71618fa6fedfb7204ef3037dca30882d15e7..3c3ae355ae5fc1f4b22c83ff38647ea95af8608c 100644
--- a/src/crankshaft/hydrogen-instructions.cc
+++ b/src/crankshaft/hydrogen-instructions.cc
@@ -831,7 +831,6 @@ bool HInstruction::CanDeoptimize() {
case HValue::kBitwise:
case HValue::kBoundsCheck:
case HValue::kBranch:
- case HValue::kCallJSFunction:
case HValue::kCallRuntime:
case HValue::kCallWithDescriptor:
case HValue::kChange:
@@ -906,28 +905,6 @@ std::ostream& HUnaryCall::PrintDataTo(std::ostream& os) const { // NOLINT
}
-std::ostream& HCallJSFunction::PrintDataTo(std::ostream& os) const { // NOLINT
- return os << NameOf(function()) << " #" << argument_count();
-}
-
-
-HCallJSFunction* HCallJSFunction::New(Isolate* isolate, Zone* zone,
- HValue* context, HValue* function,
- int argument_count) {
- bool has_stack_check = false;
- if (function->IsConstant()) {
- HConstant* fun_const = HConstant::cast(function);
- Handle<JSFunction> jsfun =
- Handle<JSFunction>::cast(fun_const->handle(isolate));
- has_stack_check = !jsfun.is_null() &&
- (jsfun->code()->kind() == Code::FUNCTION ||
- jsfun->code()->kind() == Code::OPTIMIZED_FUNCTION);
- }
-
- return new (zone) HCallJSFunction(function, argument_count, has_stack_check);
-}
-
-
std::ostream& HBinaryCall::PrintDataTo(std::ostream& os) const { // NOLINT
return os << NameOf(first()) << " " << NameOf(second()) << " #"
<< argument_count();
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698