Issue 172753003: Consistently disable the LayoutState for certain layout situations

Issue 172753003: Consistently disable the LayoutState for certain layout situations (Closed)

Created:
6 years, 10 months ago by atreat

Modified:
6 years, 10 months ago

Reviewers:
pdr., esprehn, rwlbuis, eseidel

CC:
blink-reviews, mstensho+blink_opera.com, jfernandez, philipj_slow, bemjb+rendering_chromium.org, dsinclair, Manuel Rego, zoltan1, eae+blinkwatch, leviw+renderwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, jchaffraix+rendering, svillar

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Consistently disable the LayoutState for certain layout situations Consistently disable the LayoutState for certain layout situations. Right now, each class that pushes a layout state disables it with a certain set of conditions. FrameView::performLayout also looks for disabled layout state in the subtree, but does not use the same set of conditions. This patch tries to consolidate those conditions and make them consistent as well as reducing the number of parameters for LayoutStateMaintainer constructor. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167544

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -16 lines)			Patch
M	Source/core/rendering/RenderBlock.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderBlockFlow.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderBox.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderDeprecatedFlexibleBox.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderEmbeddedObject.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderFlexibleBox.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderGrid.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderMedia.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderObject.h	View		1 chunk	+2 lines, -0 lines	1 comment	Download
M	Source/core/rendering/RenderTable.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderTableRow.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderTableSection.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderVTTCue.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderView.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderView.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pdr.

LGTM https://codereview.chromium.org/172753003/diff/70001/Source/core/rendering/RenderObject.h File Source/core/rendering/RenderObject.h (right): https://codereview.chromium.org/172753003/diff/70001/Source/core/rendering/RenderObject.h#newcode984 Source/core/rendering/RenderObject.h:984: bool shouldDisableLayoutState() const { return hasColumns() || hasTransform() ...

6 years, 10 months ago (2014-02-20 21:19:47 UTC) #2

pdr.

On 2014/02/20 21:19:47, pdr wrote: > LGTM > > https://codereview.chromium.org/172753003/diff/70001/Source/core/rendering/RenderObject.h > File Source/core/rendering/RenderObject.h (right): > ...

6 years, 10 months ago (2014-02-20 22:19:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/172753003/70001

6 years, 10 months ago (2014-02-20 22:32:04 UTC) #5

Message was sent while issue was closed.

Change committed as 167544

Expand Messages | Collapse Messages