Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 1726983002: Retire SkShader::kSupports4f_Flag (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Retire SkShader::kSupports4f_Flag No longer used except in one test. Introduce kPrefers4f_Flag instead. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726983002 Committed: https://skia.googlesource.com/skia/+/ca058f57a399f5b8b7e9b7d4382c6eb0b36cf598

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : kPrefers4f_Flag #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M include/core/SkShader.h View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M src/core/SkShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/Sk4fGradientBase.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/SkColor4fTest.cpp View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 17 (8 generated)
f(malita)
4 years, 10 months ago (2016-02-23 22:34:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726983002/20001
4 years, 10 months ago (2016-02-23 22:34:26 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-23 22:34:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/6833)
4 years, 10 months ago (2016-02-23 22:35:57 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726983002/40001
4 years, 10 months ago (2016-02-23 22:45:45 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 23:01:08 UTC) #12
reed1
lgtm https://codereview.chromium.org/1726983002/diff/40001/tests/SkColor4fTest.cpp File tests/SkColor4fTest.cpp (right): https://codereview.chromium.org/1726983002/diff/40001/tests/SkColor4fTest.cpp#newcode160 tests/SkColor4fTest.cpp:160: if (rec.fSupports4f) { I think we can even ...
4 years, 10 months ago (2016-02-24 03:01:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726983002/40001
4 years, 10 months ago (2016-02-24 03:01:21 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 03:02:23 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ca058f57a399f5b8b7e9b7d4382c6eb0b36cf598

Powered by Google App Engine
This is Rietveld 408576698