Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1726903002: Rename WorkerOrWorkletGlobalScope::script() to scriptController() (Closed)

Created:
4 years, 10 months ago by yhirano
Modified:
4 years, 9 months ago
Reviewers:
kinuko, haraken
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, horo+watch_chromium.org, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, sergeyv+blink_chromium.org, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename WorkerOrWorkletGlobalScope::script() to scriptController() This change does not change the behavior. BUG=575532 Committed: https://crrev.com/d9afcfa47179374b5b9afade26bc7df408b402a9 Cr-Commit-Position: refs/heads/master@{#377470}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -44 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ToV8.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindowTimers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerRuntimeAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 7 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/worklet/Worklet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
yhirano
I will land this CL only if https://codereview.chromium.org/1728803002/ is accepted. cc: sadrul@
4 years, 10 months ago (2016-02-23 23:13:34 UTC) #2
kinuko
lgtm. I think this one can land regardless of the other change.
4 years, 10 months ago (2016-02-24 02:09:56 UTC) #3
haraken
LGTM
4 years, 9 months ago (2016-02-24 07:34:54 UTC) #4
yhirano
Thanks, then I will land this change.
4 years, 9 months ago (2016-02-25 01:01:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726903002/20001
4 years, 9 months ago (2016-02-25 01:03:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-25 02:27:51 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-02-25 02:29:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d9afcfa47179374b5b9afade26bc7df408b402a9
Cr-Commit-Position: refs/heads/master@{#377470}

Powered by Google App Engine
This is Rietveld 408576698