third_party/WebKit/Source/modules/worklet/Worklet.cpp - Issue 1726903002: Rename WorkerOrWorkletGlobalScope::script() to scriptController()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/worklet/Worklet.cpp

Issue 1726903002: Rename WorkerOrWorkletGlobalScope::script() to scriptController() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp ('k') | third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/worklet/Worklet.cpp

diff --git a/third_party/WebKit/Source/modules/worklet/Worklet.cpp b/third_party/WebKit/Source/modules/worklet/Worklet.cpp

index bbab7dc586674ec943c9278b3ff243f8359f9979..4218b5887fe3ff91e4d510469358c26fb520ae4b 100644

--- a/third_party/WebKit/Source/modules/worklet/Worklet.cpp

+++ b/third_party/WebKit/Source/modules/worklet/Worklet.cpp

@@ -69,7 +69,7 @@ void Worklet::onFinished(WorkerScriptLoader* scriptLoader, ScriptPromiseResolver

// TODO(ikilpatrick): Worklets don't have the same error behaviour

// as workers, etc. For a SyntaxError we should reject, however if

// the script throws a normal error, resolve. For now just resolve.

- m_workletGlobalScope->script()->evaluate(ScriptSourceCode(scriptLoader->script(), scriptLoader->url()));

+ m_workletGlobalScope->scriptController()->evaluate(ScriptSourceCode(scriptLoader->script(), scriptLoader->url()));

resolver->resolve();

}

@@ -84,7 +84,7 @@ void Worklet::onFinished(WorkerScriptLoader* scriptLoader, ScriptPromiseResolver

void Worklet::stop()

{

- m_workletGlobalScope->script()->willScheduleExecutionTermination();

+ m_workletGlobalScope->scriptController()->willScheduleExecutionTermination();

for (auto scriptLoader : m_scriptLoaders) {

scriptLoader->cancel();