third_party/WebKit/Source/bindings/core/v8/ToV8.cpp - Issue 1726903002: Rename WorkerOrWorkletGlobalScope::script() to scriptController()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ToV8.cpp

Issue 1726903002: Rename WorkerOrWorkletGlobalScope::script() to scriptController() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ToV8.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp b/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp

index 1b49308f063d5a463169d5c2adb6aaa3ee36d697..237003b0b32239d355f37122fb3421c06ed17d04 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp

@@ -51,11 +51,11 @@ v8::Local<v8::Value> toV8(WorkerOrWorkletGlobalScope* impl, v8::Local<v8::Object

if (UNLIKELY(!impl))

return v8::Null(isolate);

- WorkerOrWorkletScriptController* script = impl->script();

- if (!script)

+ WorkerOrWorkletScriptController* scriptController = impl->scriptController();

+ if (!scriptController)

return v8::Null(isolate);

- v8::Local<v8::Object> global = script->context()->Global();

+ v8::Local<v8::Object> global = scriptController->context()->Global();

ASSERT(!global.IsEmpty());

return global;

}