Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 172633002: Revert 251918 "Do not send a frame swap ack from the browser unt..." (Closed)

Created:
6 years, 10 months ago by no longer working on chromium
Modified:
6 years, 10 months ago
Reviewers:
ccameron
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 251918 "Do not send a frame swap ack from the browser unt..." The bots tells this CL broke most of the webrtc browser tests on Mac. http://chromegw/i/internal.chromium.webrtc/builders/Mac%20Tester BUG=344912 TEST=webrtc bots. > Do not send a frame swap ack from the browser until the frame is drawn > > Code to do this was recently removed because it was no longer being > used in r241225 (https://codereview.chromium.org/116103002). This is > now necessary again to throttle renderers when using CoreAnimation. > > Frames are acked only when they are drawn. Both the CoreAnimation and > the non-CoreAnimation paths are changed to behave this way. By virtue > of the fact that the non-CoreAnimation path draws immediately, this > should have no functional effect on that path. > > This differs from the mechanism deleted in the aforementioned patch in > two ways. > > First, it uses a scoped_ptr of a struct instead of a vector of pairs to > store the information about the swap being returned. This should improve > readability in that the ack has struct names instead of just first and > second in the pair, and in that the scoped_ptr does not suggest support > for multiple pending swaps (which does not exist). > > Second, it does makes RWHVMac ack frames more aggressively when > inside a draw call, rather than adding a call from RWHImpl to the view, > to effect the ack (which is what the old way does). > > BUG=340133 > > Review URL: https://codereview.chromium.org/165703002 TBR=ccameron@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -115 lines) Patch
M trunk/src/content/browser/renderer_host/compositing_iosurface_layer_mac.mm View 3 chunks +29 lines, -48 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_mac.h View 2 chunks +2 lines, -19 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_mac.mm View 9 chunks +18 lines, -48 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
no longer working on chromium
6 years, 10 months ago (2014-02-19 17:43:14 UTC) #1
no longer working on chromium
Committed patchset #1 manually as r252031 (tree was closed).
6 years, 10 months ago (2014-02-19 17:43:25 UTC) #2
Niklas Enbom
6 years, 10 months ago (2014-02-19 19:41:53 UTC) #3
Message was sent while issue was closed.
Update, this revert did indeed fix all the webrtc failures.

On 2014/02/19 17:43:25, xians1 wrote:
> Committed patchset #1 manually as r252031 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698