Issue 116103002: Remove code only used by Mac single threaded compositing.

Issue 116103002: Remove code only used by Mac single threaded compositing. (Closed)

Created:
7 years ago by ccameron

Modified:
7 years ago

Reviewers:
piman

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, jamesr

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove code only used by Mac single threaded compositing. Mac single threaded compositing is no longer a shipping configuration, so remove code added to throttle swap acks for the single threaded compositor path. The Mac single threaded path will still work, but will not have a throttled framerate anymore. This will become even less relevant as the Mac moves to a browser compositor. Pull out all code associated with AboutToWaitForBackingStoreMsg, since does nothing now. Also remove some dead function prototypes. BUG=286038 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241225

Patch Set 1 #

Patch Set 2 : Pull out a bit more #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -156 lines)			Patch
M	content/browser/renderer_host/render_widget_host_impl.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_guest.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_guest.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.h	View	1	5 chunks	+0 lines, -36 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.mm	View	1	11 chunks	+16 lines, -104 lines	0 comments	Download
M	content/port/browser/render_widget_host_view_port.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/test/test_render_view_host.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/test/test_render_view_host.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ccameron

Mostly just leaning on the delete key. This makes reasoning about future changes a lot ...

7 years ago (2013-12-16 04:37:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/116103002/20001

7 years ago (2013-12-17 01:12:13 UTC) #3

Message was sent while issue was closed.

Change committed as 241225

Expand Messages | Collapse Messages