Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1725243002: Fix some warnings in Eclipse (Closed)

Created:
4 years, 10 months ago by wychen
Modified:
4 years, 7 months ago
Reviewers:
mdjones
Base URL:
git@github.com:chromium/dom-distiller.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some warnings in Eclipse - Remove unused packages, functions, and variables. - Remove unnecessary type casting. - Remove extra semicolons. - Add @Override annotations - Fix some javadoc R=mdjones@chromium.org Committed: 86376905d422a448ed589eccebe82fddc47c1ceb

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -88 lines) Patch
M java/org/chromium/distiller/DomDistiller.java View 1 chunk +0 lines, -1 line 0 comments Download
M java/org/chromium/distiller/DomDistillerEntry.java View 1 chunk +1 line, -0 lines 0 comments Download
M java/org/chromium/distiller/DomUtil.java View 1 2 chunks +2 lines, -1 line 0 comments Download
M java/org/chromium/distiller/IEReadingViewParser.java View 1 2 chunks +1 line, -14 lines 0 comments Download
M java/org/chromium/distiller/LogUtil.java View 3 chunks +4 lines, -5 lines 0 comments Download
M java/org/chromium/distiller/PageParamInfo.java View 1 1 chunk +1 line, -1 line 0 comments Download
M java/org/chromium/distiller/PageParameterDetector.java View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M java/org/chromium/distiller/PageParameterParser.java View 1 1 chunk +0 lines, -1 line 0 comments Download
M java/org/chromium/distiller/PagingLinksFinder.java View 1 4 chunks +0 lines, -22 lines 0 comments Download
M java/org/chromium/distiller/SchemaOrgParser.java View 1 1 chunk +0 lines, -1 line 0 comments Download
M java/org/chromium/distiller/StringUtil.java View 5 chunks +4 lines, -2 lines 0 comments Download
M java/org/chromium/distiller/TableClassifier.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M java/org/chromium/distiller/TreeCloneBuilder.java View 1 chunk +0 lines, -1 line 0 comments Download
M java/org/chromium/distiller/extractors/embeds/TwitterExtractor.java View 1 chunk +0 lines, -2 lines 0 comments Download
M java/org/chromium/distiller/filters/english/NumWordsRulesClassifier.java View 1 chunk +1 line, -0 lines 0 comments Download
M java/org/chromium/distiller/filters/heuristics/ExpandTitleToContentFilter.java View 1 chunk +1 line, -0 lines 0 comments Download
M java/org/chromium/distiller/filters/heuristics/LargeBlockSameTagLevelToContentFilter.java View 2 chunks +2 lines, -1 line 0 comments Download
M java/org/chromium/distiller/filters/heuristics/ListAtEndFilter.java View 1 chunk +3 lines, -2 lines 0 comments Download
M java/org/chromium/distiller/filters/simple/BoilerplateBlockFilter.java View 1 chunk +3 lines, -2 lines 0 comments Download
M java/org/chromium/distiller/filters/simple/LabelToBoilerplateFilter.java View 1 chunk +2 lines, -1 line 0 comments Download
M java/org/chromium/distiller/filters/simple/MarkEverythingBoilerplateFilter.java View 1 chunk +1 line, -0 lines 0 comments Download
M java/org/chromium/distiller/filters/simple/MarkEverythingContentFilter.java View 1 chunk +1 line, -0 lines 0 comments Download
M java/org/chromium/distiller/filters/simple/MinWordsFilter.java View 1 chunk +1 line, -0 lines 0 comments Download
M java/org/chromium/distiller/labels/LabelAction.java View 1 chunk +1 line, -0 lines 0 comments Download
M javatests/org/chromium/distiller/AssertTest.java View 18 chunks +20 lines, -0 lines 0 comments Download
M javatests/org/chromium/distiller/EmbedExtractorTest.java View 1 chunk +0 lines, -2 lines 0 comments Download
M javatests/org/chromium/distiller/IEReadingViewParserTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M javatests/org/chromium/distiller/PageParameterDetectorTest.java View 1 chunk +0 lines, -5 lines 0 comments Download
M javatests/org/chromium/distiller/PagingLinksFinderTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M javatests/org/chromium/distiller/StringUtilTest.java View 2 chunks +5 lines, -2 lines 0 comments Download
M javatests/org/chromium/distiller/TestTextDocumentBuilder.java View 1 chunk +0 lines, -3 lines 0 comments Download
M javatests/org/chromium/distiller/webdocument/WebTableTest.java View 1 chunk +0 lines, -3 lines 0 comments Download
M javatests/org/chromium/distiller/webdocument/WebTextTest.java View 1 chunk +0 lines, -2 lines 0 comments Download
M javatests/org/chromium/distiller/webdocument/WebVideoTest.java View 2 chunks +1 line, -5 lines 0 comments Download
M javatests/org/chromium/distiller/webdocument/filters/LeadImageFinderTest.java View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wychen
PTAL. This doesn't change the generated JS file.
4 years, 10 months ago (2016-02-24 20:02:38 UTC) #2
mdjones
lgtm https://codereview.chromium.org/1725243002/diff/20001/java/org/chromium/distiller/DomUtil.java File java/org/chromium/distiller/DomUtil.java (right): https://codereview.chromium.org/1725243002/diff/20001/java/org/chromium/distiller/DomUtil.java#newcode355 java/org/chromium/distiller/DomUtil.java:355: @SuppressWarnings("unused") Any idea why this is needed? The ...
4 years, 10 months ago (2016-02-24 22:24:35 UTC) #3
wychen
https://codereview.chromium.org/1725243002/diff/20001/java/org/chromium/distiller/DomUtil.java File java/org/chromium/distiller/DomUtil.java (right): https://codereview.chromium.org/1725243002/diff/20001/java/org/chromium/distiller/DomUtil.java#newcode355 java/org/chromium/distiller/DomUtil.java:355: @SuppressWarnings("unused") On 2016/02/24 22:24:35, mdjones wrote: > Any idea ...
4 years, 7 months ago (2016-05-10 22:26:38 UTC) #4
mdjones
still lgtm
4 years, 7 months ago (2016-05-12 01:02:49 UTC) #5
wychen
4 years, 7 months ago (2016-05-12 01:13:56 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
86376905d422a448ed589eccebe82fddc47c1ceb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698