Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: javatests/org/chromium/distiller/AssertTest.java

Issue 1725243002: Fix some warnings in Eclipse (Closed) Base URL: git@github.com:chromium/dom-distiller.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.distiller; 5 package org.chromium.distiller;
6 6
7 public class AssertTest extends JsTestCase { 7 public class AssertTest extends JsTestCase {
8 private static class CheckFailedException extends RuntimeException { 8 private static class CheckFailedException extends RuntimeException {
9 } 9 }
10 10
(...skipping 23 matching lines...) Expand all
34 throw new CheckFailedException(); 34 throw new CheckFailedException();
35 } 35 }
36 36
37 if (checker.test(true) != expectSuccess) { 37 if (checker.test(true) != expectSuccess) {
38 throw new CheckFailedException(); 38 throw new CheckFailedException();
39 } 39 }
40 } 40 }
41 41
42 public void testCheck() { 42 public void testCheck() {
43 Checker passer = new Checker() { 43 Checker passer = new Checker() {
44 @Override
44 void run(boolean withMessage) { 45 void run(boolean withMessage) {
45 } 46 }
46 }; 47 };
47 Checker failer = new Checker() { 48 Checker failer = new Checker() {
49 @Override
48 void run(boolean withMessage) { 50 void run(boolean withMessage) {
49 fail(); 51 fail();
50 } 52 }
51 }; 53 };
52 54
53 // These should not throw exceptions. 55 // These should not throw exceptions.
54 check(true, passer); 56 check(true, passer);
55 check(false, failer); 57 check(false, failer);
56 58
57 // Each of these should fail. 59 // Each of these should fail.
58 try { 60 try {
59 check(false, passer); 61 check(false, passer);
60 fail(); 62 fail();
61 } catch (CheckFailedException e) { 63 } catch (CheckFailedException e) {
62 } 64 }
63 65
64 try { 66 try {
65 check(true, failer); 67 check(true, failer);
66 fail(); 68 fail();
67 } catch (CheckFailedException e) { 69 } catch (CheckFailedException e) {
68 } 70 }
69 71
70 // A Checker's success/failure is expected to be consistent across null/ non-null messages. 72 // A Checker's success/failure is expected to be consistent across null/ non-null messages.
71 // If not, check should fail regardless of the expectedSuccess value. 73 // If not, check should fail regardless of the expectedSuccess value.
72 Checker nullFailer = new Checker() { 74 Checker nullFailer = new Checker() {
75 @Override
73 void run(boolean withMessage) { 76 void run(boolean withMessage) {
74 if (!withMessage) fail(); 77 if (!withMessage) fail();
75 } 78 }
76 }; 79 };
77 Checker stringFailer = new Checker() { 80 Checker stringFailer = new Checker() {
81 @Override
78 void run(boolean withMessage) { 82 void run(boolean withMessage) {
79 if (withMessage) fail(); 83 if (withMessage) fail();
80 } 84 }
81 }; 85 };
82 86
83 try { 87 try {
84 check(true, nullFailer); 88 check(true, nullFailer);
85 fail(); 89 fail();
86 } catch (CheckFailedException e) { 90 } catch (CheckFailedException e) {
87 } 91 }
(...skipping 14 matching lines...) Expand all
102 check(false, stringFailer); 106 check(false, stringFailer);
103 fail(); 107 fail();
104 } catch (CheckFailedException e) { 108 } catch (CheckFailedException e) {
105 } 109 }
106 } 110 }
107 111
108 private static void checkArrayEquals(boolean expectSuccess, 112 private static void checkArrayEquals(boolean expectSuccess,
109 final char[] expecteds, 113 final char[] expecteds,
110 final char[] actuals) { 114 final char[] actuals) {
111 check(expectSuccess, new Checker() { 115 check(expectSuccess, new Checker() {
116 @Override
112 void run(boolean withMessage) { 117 void run(boolean withMessage) {
113 if (withMessage) { 118 if (withMessage) {
114 assertArrayEquals("", expecteds, actuals); 119 assertArrayEquals("", expecteds, actuals);
115 } else { 120 } else {
116 assertArrayEquals(expecteds, actuals); 121 assertArrayEquals(expecteds, actuals);
117 } 122 }
118 } 123 }
119 }); 124 });
120 } 125 }
121 126
122 private static void checkArrayEquals(boolean expectSuccess, 127 private static void checkArrayEquals(boolean expectSuccess,
123 final byte[] expecteds, 128 final byte[] expecteds,
124 final byte[] actuals) { 129 final byte[] actuals) {
125 check(expectSuccess, new Checker() { 130 check(expectSuccess, new Checker() {
131 @Override
126 void run(boolean withMessage) { 132 void run(boolean withMessage) {
127 if (withMessage) { 133 if (withMessage) {
128 assertArrayEquals("", expecteds, actuals); 134 assertArrayEquals("", expecteds, actuals);
129 } else { 135 } else {
130 assertArrayEquals(expecteds, actuals); 136 assertArrayEquals(expecteds, actuals);
131 } 137 }
132 } 138 }
133 }); 139 });
134 } 140 }
135 141
136 private static void checkArrayEquals(boolean expectSuccess, 142 private static void checkArrayEquals(boolean expectSuccess,
137 final short[] expecteds, 143 final short[] expecteds,
138 final short[] actuals) { 144 final short[] actuals) {
139 check(expectSuccess, new Checker() { 145 check(expectSuccess, new Checker() {
146 @Override
140 void run(boolean withMessage) { 147 void run(boolean withMessage) {
141 if (withMessage) { 148 if (withMessage) {
142 assertArrayEquals("", expecteds, actuals); 149 assertArrayEquals("", expecteds, actuals);
143 } else { 150 } else {
144 assertArrayEquals(expecteds, actuals); 151 assertArrayEquals(expecteds, actuals);
145 } 152 }
146 } 153 }
147 }); 154 });
148 } 155 }
149 156
150 private static void checkArrayEquals(boolean expectSuccess, 157 private static void checkArrayEquals(boolean expectSuccess,
151 final int[] expecteds, 158 final int[] expecteds,
152 final int[] actuals) { 159 final int[] actuals) {
153 check(expectSuccess, new Checker() { 160 check(expectSuccess, new Checker() {
161 @Override
154 void run(boolean withMessage) { 162 void run(boolean withMessage) {
155 if (withMessage) { 163 if (withMessage) {
156 assertArrayEquals("", expecteds, actuals); 164 assertArrayEquals("", expecteds, actuals);
157 } else { 165 } else {
158 assertArrayEquals(expecteds, actuals); 166 assertArrayEquals(expecteds, actuals);
159 } 167 }
160 } 168 }
161 }); 169 });
162 } 170 }
163 171
164 private static void checkArrayEquals(boolean expectSuccess, 172 private static void checkArrayEquals(boolean expectSuccess,
165 final long[] expecteds, 173 final long[] expecteds,
166 final long[] actuals) { 174 final long[] actuals) {
167 check(expectSuccess, new Checker() { 175 check(expectSuccess, new Checker() {
176 @Override
168 void run(boolean withMessage) { 177 void run(boolean withMessage) {
169 if (withMessage) { 178 if (withMessage) {
170 assertArrayEquals("", expecteds, actuals); 179 assertArrayEquals("", expecteds, actuals);
171 } else { 180 } else {
172 assertArrayEquals(expecteds, actuals); 181 assertArrayEquals(expecteds, actuals);
173 } 182 }
174 } 183 }
175 }); 184 });
176 } 185 }
177 186
178 private static void checkArrayEquals(boolean expectSuccess, 187 private static void checkArrayEquals(boolean expectSuccess,
179 final Object[] expecteds, 188 final Object[] expecteds,
180 final Object[] actuals) { 189 final Object[] actuals) {
181 check(expectSuccess, new Checker() { 190 check(expectSuccess, new Checker() {
191 @Override
182 void run(boolean withMessage) { 192 void run(boolean withMessage) {
183 if (withMessage) { 193 if (withMessage) {
184 assertArrayEquals("", expecteds, actuals); 194 assertArrayEquals("", expecteds, actuals);
185 } else { 195 } else {
186 assertArrayEquals(expecteds, actuals); 196 assertArrayEquals(expecteds, actuals);
187 } 197 }
188 } 198 }
189 }); 199 });
190 } 200 }
191 201
192 private static void checkEquals(boolean expectSuccess, 202 private static void checkEquals(boolean expectSuccess,
193 final double expected, 203 final double expected,
194 final double actual, 204 final double actual,
195 final double delta) { 205 final double delta) {
196 check(expectSuccess, new Checker() { 206 check(expectSuccess, new Checker() {
207 @Override
197 void run(boolean withMessage) { 208 void run(boolean withMessage) {
198 if (withMessage) { 209 if (withMessage) {
199 assertEquals("", expected, actual, delta); 210 assertEquals("", expected, actual, delta);
200 } else { 211 } else {
201 assertEquals(expected, actual, delta); 212 assertEquals(expected, actual, delta);
202 } 213 }
203 } 214 }
204 }); 215 });
205 } 216 }
206 217
207 private static void checkEquals(boolean expectSuccess, 218 private static void checkEquals(boolean expectSuccess,
208 final long expected, 219 final long expected,
209 final long actual) { 220 final long actual) {
210 check(expectSuccess, new Checker() { 221 check(expectSuccess, new Checker() {
222 @Override
211 void run(boolean withMessage) { 223 void run(boolean withMessage) {
212 if (withMessage) { 224 if (withMessage) {
213 assertEquals("", expected, actual); 225 assertEquals("", expected, actual);
214 } else { 226 } else {
215 assertEquals(expected, actual); 227 assertEquals(expected, actual);
216 } 228 }
217 } 229 }
218 }); 230 });
219 } 231 }
220 232
221 private static void checkEquals(boolean expectSuccess, 233 private static void checkEquals(boolean expectSuccess,
222 final Object expected, 234 final Object expected,
223 final Object actual) { 235 final Object actual) {
224 check(expectSuccess, new Checker() { 236 check(expectSuccess, new Checker() {
237 @Override
225 void run(boolean withMessage) { 238 void run(boolean withMessage) {
226 if (withMessage) { 239 if (withMessage) {
227 assertEquals("", expected, actual); 240 assertEquals("", expected, actual);
228 } else { 241 } else {
229 assertEquals(expected, actual); 242 assertEquals(expected, actual);
230 } 243 }
231 } 244 }
232 }); 245 });
233 } 246 }
234 247
235 private static void checkAssertFalse(boolean expectSuccess, 248 private static void checkAssertFalse(boolean expectSuccess,
236 final boolean value) { 249 final boolean value) {
237 check(expectSuccess, new Checker() { 250 check(expectSuccess, new Checker() {
251 @Override
238 void run(boolean withMessage) { 252 void run(boolean withMessage) {
239 if (withMessage) { 253 if (withMessage) {
240 assertFalse("", value); 254 assertFalse("", value);
241 } else { 255 } else {
242 assertFalse(value); 256 assertFalse(value);
243 } 257 }
244 } 258 }
245 }); 259 });
246 } 260 }
247 261
248 private static void checkAssertTrue(boolean expectSuccess, 262 private static void checkAssertTrue(boolean expectSuccess,
249 final boolean value) { 263 final boolean value) {
250 check(expectSuccess, new Checker() { 264 check(expectSuccess, new Checker() {
265 @Override
251 void run(boolean withMessage) { 266 void run(boolean withMessage) {
252 if (withMessage) { 267 if (withMessage) {
253 assertTrue("", value); 268 assertTrue("", value);
254 } else { 269 } else {
255 assertTrue(value); 270 assertTrue(value);
256 } 271 }
257 } 272 }
258 }); 273 });
259 } 274 }
260 275
261 276
262 private static void checkAssertNull(boolean expectSuccess, 277 private static void checkAssertNull(boolean expectSuccess,
263 final Object value) { 278 final Object value) {
264 check(expectSuccess, new Checker() { 279 check(expectSuccess, new Checker() {
280 @Override
265 void run(boolean withMessage) { 281 void run(boolean withMessage) {
266 if (withMessage) { 282 if (withMessage) {
267 assertNull("", value); 283 assertNull("", value);
268 } else { 284 } else {
269 assertNull(value); 285 assertNull(value);
270 } 286 }
271 } 287 }
272 }); 288 });
273 } 289 }
274 290
275 private static void checkAssertNotNull(boolean expectSuccess, 291 private static void checkAssertNotNull(boolean expectSuccess,
276 final Object value) { 292 final Object value) {
277 check(expectSuccess, new Checker() { 293 check(expectSuccess, new Checker() {
294 @Override
278 void run(boolean withMessage) { 295 void run(boolean withMessage) {
279 if (withMessage) { 296 if (withMessage) {
280 assertNotNull("", value); 297 assertNotNull("", value);
281 } else { 298 } else {
282 assertNotNull(value); 299 assertNotNull(value);
283 } 300 }
284 } 301 }
285 }); 302 });
286 } 303 }
287 304
288 private static void checkAssertSame(boolean expectSuccess, 305 private static void checkAssertSame(boolean expectSuccess,
289 final Object expected, 306 final Object expected,
290 final Object actual) { 307 final Object actual) {
291 check(expectSuccess, new Checker() { 308 check(expectSuccess, new Checker() {
309 @Override
292 void run(boolean withMessage) { 310 void run(boolean withMessage) {
293 if (withMessage) { 311 if (withMessage) {
294 assertSame("", expected, actual); 312 assertSame("", expected, actual);
295 } else { 313 } else {
296 assertSame(expected, actual); 314 assertSame(expected, actual);
297 } 315 }
298 } 316 }
299 }); 317 });
300 } 318 }
301 319
302 private static void checkAssertNotSame(boolean expectSuccess, 320 private static void checkAssertNotSame(boolean expectSuccess,
303 final Object expected, 321 final Object expected,
304 final Object actual) { 322 final Object actual) {
305 check(expectSuccess, new Checker() { 323 check(expectSuccess, new Checker() {
324 @Override
306 void run(boolean withMessage) { 325 void run(boolean withMessage) {
307 if (withMessage) { 326 if (withMessage) {
308 assertNotSame("", expected, actual); 327 assertNotSame("", expected, actual);
309 } else { 328 } else {
310 assertNotSame(expected, actual); 329 assertNotSame(expected, actual);
311 } 330 }
312 } 331 }
313 }); 332 });
314 } 333 }
315 334
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
461 assertTrue(v.equals(o)); 480 assertTrue(v.equals(o));
462 checkAssertNotSame(false, v, v); 481 checkAssertNotSame(false, v, v);
463 checkAssertNotSame(false, null, null); 482 checkAssertNotSame(false, null, null);
464 checkAssertNotSame(false, "", ""); 483 checkAssertNotSame(false, "", "");
465 checkAssertNotSame(true, v, ""); 484 checkAssertNotSame(true, v, "");
466 checkAssertNotSame(true, v, o); 485 checkAssertNotSame(true, v, o);
467 } 486 }
468 487
469 public void testFail() { 488 public void testFail() {
470 check(false, new Checker() { 489 check(false, new Checker() {
490 @Override
471 void run(boolean withMessage) { 491 void run(boolean withMessage) {
472 if (withMessage) { 492 if (withMessage) {
473 fail(""); 493 fail("");
474 } else { 494 } else {
475 fail(); 495 fail();
476 } 496 }
477 } 497 }
478 }); 498 });
479 } 499 }
480 } 500 }
OLDNEW
« no previous file with comments | « java/org/chromium/distiller/labels/LabelAction.java ('k') | javatests/org/chromium/distiller/EmbedExtractorTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698