Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Side by Side Diff: java/org/chromium/distiller/PageParameterDetector.java

Issue 1725243002: Fix some warnings in Eclipse (Closed) Base URL: git@github.com:chromium/dom-distiller.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.distiller; 5 package org.chromium.distiller;
6 6
7 import com.google.gwt.regexp.shared.MatchResult; 7 import com.google.gwt.regexp.shared.MatchResult;
8 import com.google.gwt.regexp.shared.RegExp; 8 import com.google.gwt.regexp.shared.RegExp;
9 9
10 import java.util.ArrayList; 10 import java.util.ArrayList;
11 import java.util.Arrays;
12 import java.util.Collections; 11 import java.util.Collections;
13 import java.util.HashMap; 12 import java.util.HashMap;
14 import java.util.HashSet; 13 import java.util.HashSet;
15 import java.util.List; 14 import java.util.List;
16 import java.util.Map; 15 import java.util.Map;
17 import java.util.Set; 16 import java.util.Set;
18 17
19 /** 18 /**
20 * Background: 19 * Background:
21 * The long article/news/forum thread/blog document may be partitioned into se veral partial pages 20 * The long article/news/forum thread/blog document may be partitioned into se veral partial pages
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 static final int MAX_PAGING_DOCS = 100; 56 static final int MAX_PAGING_DOCS = 100;
58 57
59 /** 58 /**
60 * The interface that page pattern handlers must implement to detect page pa rameter from 59 * The interface that page pattern handlers must implement to detect page pa rameter from
61 * potential pagination URLs. 60 * potential pagination URLs.
62 */ 61 */
63 interface PagePattern { 62 interface PagePattern {
64 /** 63 /**
65 * Returns the string of the URL page pattern. 64 * Returns the string of the URL page pattern.
66 */ 65 */
66 @Override
mdjones 2016/02/24 22:24:35 I would have thought this would be applied to the
wychen 2016/05/10 22:26:37 You are right. Done.
67 String toString(); 67 String toString();
68 68
69 /** 69 /**
70 * Returns the page number extracted from the URL during creation of obje ct that implements 70 * Returns the page number extracted from the URL during creation of obje ct that implements
71 * this interface. 71 * this interface.
72 */ 72 */
73 int getPageNumber(); 73 int getPageNumber();
74 74
75 /** 75 /**
76 * Validates this page pattern according to the current document URL thr ough a pipeline of 76 * Validates this page pattern according to the current document URL thr ough a pipeline of
(...skipping 397 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 sBadPageParamNames.add("subscriptions"); 474 sBadPageParamNames.add("subscriptions");
475 sBadPageParamNames.add("tag"); 475 sBadPageParamNames.add("tag");
476 sBadPageParamNames.add("tags"); 476 sBadPageParamNames.add("tags");
477 sBadPageParamNames.add("video"); 477 sBadPageParamNames.add("video");
478 sBadPageParamNames.add("videos"); 478 sBadPageParamNames.add("videos");
479 sBadPageParamNames.add("w"); 479 sBadPageParamNames.add("w");
480 sBadPageParamNames.add("wiki"); 480 sBadPageParamNames.add("wiki");
481 } 481 }
482 482
483 } 483 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698