[safe browsing] Remove stale BINHASH code.

[safe browsing] Remove stale BINHASH code.

Safe browsing stopped requesting the download hash list a few years ago,
and the histograms from r150369 (Delete stale chunks from safe-browsing
downloads store) no longer show any hits at all.  Remove remaining stale
code.

BUG=108130
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252630

[mattm, 2014-02-19 23:47:09]

lgtm 
Thanks Scott!

https://codereview.chromium.org/172393005/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/safe_browsing_database.cc (right):

https://codereview.chromium.org/172393005/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/safe_browsing_database.cc:1147: // at all, so it
has been removed.  Everything _should_ be resilient to extra
Looks like the histograms just don't show on the dashboard since there was no
description added to histograms.xml for them. If you wanted to be extra safe you
could add the descriptions, wait for the dashboard to be updated, and check the
results.  But since the removal code has been in there for many versions now I'm
fine with just killing it.

[Scott Hess - ex-Googler, 2014-02-20 00:28:00]

On 2014/02/19 23:47:09, mattm wrote:
> lgtm 
> Thanks Scott!
> 
>
https://codereview.chromium.org/172393005/diff/1/chrome/browser/safe_browsing...
> File chrome/browser/safe_browsing/safe_browsing_database.cc (right):
> 
>
https://codereview.chromium.org/172393005/diff/1/chrome/browser/safe_browsing...
> chrome/browser/safe_browsing/safe_browsing_database.cc:1147: // at all, so it
> has been removed.  Everything _should_ be resilient to extra
> Looks like the histograms just don't show on the dashboard since there was no
> description added to histograms.xml for them. If you wanted to be extra safe
you
> could add the descriptions, wait for the dashboard to be updated, and check
the
> results.  But since the removal code has been in there for many versions now
I'm
> fine with just killing it.

I was like 99% convinced that I had figured out a way to look at the histograms
with the raw hash code, but I can't figure it out, now.  Maybe I was mistaken. 
I put up another CL to mod histograms.xml.  Really checking it won't kill
anyone.

[Scott Hess - ex-Googler, 2014-02-20 19:13:20]

Thanks.

https://codereview.chromium.org/172393005/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/safe_browsing_database.cc (right):

https://codereview.chromium.org/172393005/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/safe_browsing_database.cc:1147: // at all, so it
has been removed.  Everything _should_ be resilient to extra
On 2014/02/19 23:47:09, mattm wrote:
> Looks like the histograms just don't show on the dashboard since there was no
> description added to histograms.xml for them. If you wanted to be extra safe
you
> could add the descriptions, wait for the dashboard to be updated, and check
the
> results.  But since the removal code has been in there for many versions now
I'm
> fine with just killing it.

I updated histograms.xml, and now the dashboard shows that we have odd users. 
~15k/day cases where something is deleted.  I have no idea what those users are
doing, it seems unlikely to me that there are this many people per day who have
not launched Chrome for 18 months, but today is the day!  But if there are,
well, there's not really all that much we could do that will impact them.  I
think it's more likely that they have something funky going on outside of
Chrome, like a pre-built profile (say for a testing VM), but I can't think of
any reason to keep the code in that case, either.

I will change the comment, though.

[It just occurred to me that if a user has some sort of corruption which
prevents the update from succeeding, then they might hit this histogram every 45
minutes or so.  I don't know what would cause that, but that could cut the
incidence down to as few as 500 users/day.]

[Scott Hess - ex-Googler, 2014-02-20 19:13:30]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2014-02-20 19:14:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/172393005/100001

[commit-bot: I haz the power, 2014-02-21 19:10:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/172393005/100001

[Paweł Hajdan Jr., 2014-02-21 19:10:25]

The CQ bit was unchecked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2014-02-21 19:12:31]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-02-21 20:25:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 20:25:15]

List of reviewers changed. phajdan.jr@chromium.org did a drive-by without
LGTM'ing!

[Scott Hess - ex-Googler, 2014-02-21 20:26:02]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2014-02-21 20:27:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/172393005/100001

[commit-bot: I haz the power, 2014-02-21 20:29:54]

Change committed as 252630