Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: chrome/browser/safe_browsing/database_manager.h

Issue 172393005: [safe browsing] Remove stale BINHASH code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update histogram info in comment. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/database_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/database_manager.h
diff --git a/chrome/browser/safe_browsing/database_manager.h b/chrome/browser/safe_browsing/database_manager.h
index 84653679e28eb3b171ee90f06826961403069083..bba2d676815a713bd39db02004252b7db09f8dc5 100644
--- a/chrome/browser/safe_browsing/database_manager.h
+++ b/chrome/browser/safe_browsing/database_manager.h
@@ -106,10 +106,6 @@ class SafeBrowsingDatabaseManager
virtual void OnCheckDownloadUrlResult(const std::vector<GURL>& url_chain,
SBThreatType threat_type) {}
- // Called when the result of checking a download binary hash is known.
- virtual void OnCheckDownloadHashResult(const std::string& hash,
- SBThreatType threat_type) {}
-
// Called when the result of checking a set of extensions is known.
virtual void OnCheckExtensionsResult(
const std::set<std::string>& threats) {}
@@ -138,10 +134,6 @@ class SafeBrowsingDatabaseManager
virtual bool CheckDownloadUrl(const std::vector<GURL>& url_chain,
Client* client);
- // Check if the prefix for |full_hash| is in safebrowsing binhash add lists.
- // Result will be passed to callback in |client|.
- virtual bool CheckDownloadHash(const std::string& full_hash, Client* client);
-
// Check which prefixes in |extension_ids| are in the safebrowsing blacklist.
// Returns true if not, false if further checks need to be made in which case
// the result will be passed to |client|.
@@ -322,9 +314,6 @@ class SafeBrowsingDatabaseManager
bool HandleOneCheck(SafeBrowsingCheck* check,
const std::vector<SBFullHashResult>& full_hashes);
- // Checks the download hash on safe_browsing_thread_.
- void CheckDownloadHashOnSBThread(SafeBrowsingCheck* check);
-
// Invoked by CheckDownloadUrl. It checks the download URL on
// safe_browsing_thread_.
void CheckDownloadUrlOnSBThread(SafeBrowsingCheck* check);
@@ -336,9 +325,6 @@ class SafeBrowsingDatabaseManager
// Calls the Client's callback on IO thread after CheckDownloadUrl finishes.
void CheckDownloadUrlDone(SafeBrowsingCheck* check);
- // Calls the Client's callback on IO thread after CheckDownloadHash finishes.
- void CheckDownloadHashDone(SafeBrowsingCheck* check);
-
// Checks all extension ID hashes on safe_browsing_thread_.
void CheckExtensionIDsOnSBThread(SafeBrowsingCheck* check);
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/database_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698