Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3899)

Unified Diff: chrome/browser/safe_browsing/protocol_parser.cc

Issue 172393005: [safe browsing] Remove stale BINHASH code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update histogram info in comment. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/protocol_parser.cc
diff --git a/chrome/browser/safe_browsing/protocol_parser.cc b/chrome/browser/safe_browsing/protocol_parser.cc
index 035de5cd4837bb41c7e52c53772d0b5f9e9ab1f4..1fb64ef7521eb8ac9a62748d8eec75e055ad4eab 100644
--- a/chrome/browser/safe_browsing/protocol_parser.cc
+++ b/chrome/browser/safe_browsing/protocol_parser.cc
@@ -263,8 +263,7 @@ bool SafeBrowsingProtocolParser::ParseAddChunk(const std::string& list_name,
SBEntry::Type type = hash_len == sizeof(SBPrefix) ?
SBEntry::ADD_PREFIX : SBEntry::ADD_FULL_HASH;
- if (list_name == safe_browsing_util::kBinHashList ||
- list_name == safe_browsing_util::kDownloadWhiteList ||
+ if (list_name == safe_browsing_util::kDownloadWhiteList ||
list_name == safe_browsing_util::kExtensionBlacklist ||
list_name == safe_browsing_util::kIPBlacklist) {
// These lists only contain prefixes, no HOSTKEY and COUNT.
@@ -313,14 +312,13 @@ bool SafeBrowsingProtocolParser::ParseSubChunk(const std::string& list_name,
SBEntry::Type type = hash_len == sizeof(SBPrefix) ?
SBEntry::SUB_PREFIX : SBEntry::SUB_FULL_HASH;
- if (list_name == safe_browsing_util::kBinHashList ||
- list_name == safe_browsing_util::kDownloadWhiteList ||
+ if (list_name == safe_browsing_util::kDownloadWhiteList ||
list_name == safe_browsing_util::kExtensionBlacklist ||
list_name == safe_browsing_util::kIPBlacklist) {
SBChunkHost chunk_host;
- // Set host to 0 and it won't be used for kBinHashList.
+ // Set host to 0 and it won't be used.
chunk_host.host = 0;
- // kBinHashList only contains (add_chunk_number, prefix) pairs, no HOSTKEY
+ // lists only contain (add_chunk_number, prefix) pairs, no HOSTKEY
// and COUNT. |add_chunk_number| is int32.
prefix_count = remaining / (sizeof(int32) + hash_len);
chunk_host.entry = SBEntry::Create(type, prefix_count);
« no previous file with comments | « chrome/browser/safe_browsing/ping_manager_unittest.cc ('k') | chrome/browser/safe_browsing/protocol_parser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698