Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1723663005: Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (Closed)

Created:
4 years, 10 months ago by engedy
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, dgozman, pfeldman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, mlamouri+watch-test-runner_chromium.org, pfeldman+blink_chromium.org, mlamouri+watch-screen-orientation_chromium.org, jam, mlamouri+watch-blink_chromium.org, lushnikov+blink_chromium.org, blink-reviews, dglazkov+blink, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, blink-reviews-api_chromium.org, jochen+watch_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (patchset #5 id:80001 of https://codereview.chromium.org/1711083002/ ) Reason for revert: Suspected of breaking "fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html" on Webkit Linux Leak: -FAIL window.cached_screen_orientation.type should be . Was portrait-primary. +FAIL window.cached_screen_orientation.type should be . Was landscape-primary. See: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/17650 Original issue's description: > [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. > > This unifies screen orientation with the rest of screen emulation > and covers window.orientation API. > > BUG=585185 > > Committed: https://crrev.com/c7185a793efbeaa40e0d20d9d953bc1e2c32f5d1 > Cr-Commit-Position: refs/heads/master@{#376822} TBR=pfeldman@chromium.org,tsepez@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585185 Committed: https://crrev.com/abf86fd83c48a4dfa3f059f2db732fbb11cb614d Cr-Commit-Position: refs/heads/master@{#376976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -181 lines) Patch
M components/test_runner/mock_screen_orientation_client.h View 2 chunks +0 lines, -2 lines 0 comments Download
M components/test_runner/mock_screen_orientation_client.cc View 2 chunks +1 line, -4 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/emulation_handler.h View 1 chunk +12 lines, -14 lines 0 comments Download
M content/browser/devtools/protocol/emulation_handler.cc View 4 chunks +1 line, -42 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/devtools/render_widget_screen_metrics_emulator.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/screen-orientation-override.html View 3 chunks +19 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt View 2 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 7 chunks +28 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 4 chunks +28 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.h View 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp View 5 chunks +31 lines, -5 lines 0 comments Download
A third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.h View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.cpp View 1 chunk +112 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebDeviceEmulationParams.h View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
engedy
Created Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator.
4 years, 10 months ago (2016-02-23 14:02:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723663005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723663005/1
4 years, 10 months ago (2016-02-23 14:03:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 14:05:36 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abf86fd83c48a4dfa3f059f2db732fbb11cb614d Cr-Commit-Position: refs/heads/master@{#376976}
4 years, 10 months ago (2016-02-23 14:06:39 UTC) #6
engedy
4 years, 10 months ago (2016-02-23 14:13:35 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1722643003/ by engedy@chromium.org.

The reason for reverting is: Meh, revert broke the tree. Revert revert, will
investigate later..

Powered by Google App Engine
This is Rietveld 408576698