DescriptionRevert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (patchset #5 id:80001 of https://codereview.chromium.org/1711083002/ )
Reason for revert:
Suspected of breaking "fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html" on Webkit Linux Leak:
-FAIL window.cached_screen_orientation.type should be . Was portrait-primary.
+FAIL window.cached_screen_orientation.type should be . Was landscape-primary.
See: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/17650
Original issue's description:
> [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator.
>
> This unifies screen orientation with the rest of screen emulation
> and covers window.orientation API.
>
> BUG=585185
>
> Committed: https://crrev.com/c7185a793efbeaa40e0d20d9d953bc1e2c32f5d1
> Cr-Commit-Position: refs/heads/master@{#376822}
TBR=pfeldman@chromium.org,tsepez@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=585185
Committed: https://crrev.com/abf86fd83c48a4dfa3f059f2db732fbb11cb614d
Cr-Commit-Position: refs/heads/master@{#376976}
Patch Set 1 #Messages
Total messages: 7 (2 generated)
|