third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt - Issue 1723663005: Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt

Issue 1723663005: Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/screen-orientation-override.html ('k') | third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt

diff --git a/third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt b/third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt

index e76a33074d3a8395f6eeff24bec72529c20be1ca..ebcf1dffaacf017008481de7cf395394f9d867d2 100644

--- a/third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt

+++ b/third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt

@@ -1,18 +1,15 @@

-CONSOLE MESSAGE: line 22: angle: 0; type: portrait-primary

-CONSOLE MESSAGE: line 22: angle: 180; type: portrait-secondary

-CONSOLE MESSAGE: line 22: angle: 90; type: landscape-primary

-CONSOLE MESSAGE: line 22: angle: 270; type: landscape-secondary

Running: initial

+angle: 90; type: landscape-primary

Running: setWrongAngle1

-error: Request Emulation.setDeviceMetricsOverride failed. {"code":-32602,"message":"Missing or invalid 'Screen orientation angle must be non-negative, less than 360' parameter"}

+Angle should be in [0; 360) interval

Running: setWrongAngle2

-error: Request Emulation.setDeviceMetricsOverride failed. {"code":-32602,"message":"Missing or invalid 'Screen orientation angle must be non-negative, less than 360' parameter"}

+Angle should be in [0; 360) interval

Running: setWrongType

-error: Request Emulation.setDeviceMetricsOverride failed. {"code":-32602,"message":"Missing or invalid 'Invalid screen orientation type value' parameter"}

+Wrong type value

Running: setPortraitPrimary

angle: 0; type: portrait-primary

@@ -31,5 +28,5 @@

angle: 270; type: landscape-secondary

Running: clearOverride

-Equals to initial: true

+angle: 90; type: landscape-primary