content/browser/devtools/protocol/emulation_handler.h - Issue 1723663005: Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/emulation_handler.h

Issue 1723663005: Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_handler_generator.py ('k') | content/browser/devtools/protocol/emulation_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/emulation_handler.h

diff --git a/content/browser/devtools/protocol/emulation_handler.h b/content/browser/devtools/protocol/emulation_handler.h

index a5aec635500fae712f37874d67afd8b539805a01..bcaeb0d04102ff2443d773230f60b496057267ec 100644

--- a/content/browser/devtools/protocol/emulation_handler.h

+++ b/content/browser/devtools/protocol/emulation_handler.h

@@ -39,20 +39,18 @@

const std::string* configuration);

Response CanEmulate(bool* result);

- Response SetDeviceMetricsOverride(

- int width,

- int height,

- double device_scale_factor,

- bool mobile,

- bool fit_window,

- const double* optional_scale,

- const double* optional_offset_x,

- const double* optional_offset_y,

- const int* screen_widget,

- const int* screen_height,

- const int* position_x,

- const int* position_y,

- const scoped_ptr<base::DictionaryValue>& screen_orientation);

+ Response SetDeviceMetricsOverride(int width,

+ int height,

+ double device_scale_factor,

+ bool mobile,

+ bool fit_window,

+ const double* optional_scale,

+ const double* optional_offset_x,

+ const double* optional_offset_y,

+ const int* screen_widget,

+ const int* screen_height,

+ const int* position_x,

+ const int* position_y);

Response ClearDeviceMetricsOverride();

private: