third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/save_password_infobar_delegate.cc ('K') | « third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html ('k') | third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h

diff --git a/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h b/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h

index c52e769b222dc202def2efd7d49ef8d62e5f676e..c4b9657a04c3844015969e1b94bb4879e35c132f 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h

+++ b/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h

@@ -23,10 +23,10 @@ public:

static FederatedCredential* create(WebFederatedCredential*);

// FederatedCredential.idl

- const KURL& provider() const;

+ const String provider() const;

// TODO(mkwst): This is a stub, as we don't yet have any support on the Chromium-side.

- const String protocol() const { return String(); }

+ const String& protocol() const { return emptyString(); }

private:

FederatedCredential(WebFederatedCredential*);