third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/save_password_infobar_delegate.cc ('K') | « third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h ('k') | third_party/WebKit/Source/platform/credentialmanager/PlatformFederatedCredential.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp b/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp

index 8686178cba40f39294bed4cd45c7f90030e41b59..a1d5b008f35771434c3c02ff1c88930d0c16d4cb 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp

@@ -7,6 +7,7 @@

#include "bindings/core/v8/ExceptionState.h"

#include "modules/credentialmanager/FederatedCredentialData.h"

#include "platform/credentialmanager/PlatformFederatedCredential.h"

+#include "platform/weborigin/SecurityOrigin.h"

#include "public/platform/WebFederatedCredential.h"

namespace blink {

@@ -31,13 +32,13 @@ FederatedCredential::FederatedCredential(WebFederatedCredential* webFederatedCre

}

FederatedCredential::FederatedCredential(const String& id, const KURL& provider, const String& name, const KURL& icon)

- : Credential(PlatformFederatedCredential::create(id, provider, name, icon))

+ : Credential(PlatformFederatedCredential::create(id, SecurityOrigin::create(provider), name, icon))

{

}

-const KURL& FederatedCredential::provider() const

+const String FederatedCredential::provider() const

{

- return static_cast<PlatformFederatedCredential*>(m_platformCredential.get())->provider();

+ return static_cast<PlatformFederatedCredential*>(m_platformCredential.get())->provider()->toString();

}

} // namespace blink