components/password_manager/core/browser/password_manager_util_unittest.cc - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_util_unittest.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/save_password_infobar_delegate.cc ('K') | « components/password_manager/core/browser/password_manager_util.cc ('k') | components/password_manager/core/browser/password_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_util_unittest.cc

diff --git a/components/password_manager/core/browser/password_manager_util_unittest.cc b/components/password_manager/core/browser/password_manager_util_unittest.cc

index 6b29f1a6f8bc5b0bc701cc0090675f505510cd3f..bb963cc5cda0ba775c45a18d0e68676871a3ee79 100644

--- a/components/password_manager/core/browser/password_manager_util_unittest.cc

+++ b/components/password_manager/core/browser/password_manager_util_unittest.cc

@@ -44,7 +44,7 @@ TEST(PasswordManagerUtil, TrimUsernameOnlyCredentials) {

username_only.username_value = base::ASCIIToUTF16(kTestUsername2);

forms.push_back(new autofill::PasswordForm(username_only));

- username_only.federation_url = GURL(kTestFederationURL);

+ username_only.federation_origin = url::Origin(GURL(kTestFederationURL));

username_only.skip_zero_click = false;

forms.push_back(new autofill::PasswordForm(username_only));

username_only.skip_zero_click = true;