Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: components/password_manager/core/browser/password_manager_util.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS2 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_util.cc
diff --git a/components/password_manager/core/browser/password_manager_util.cc b/components/password_manager/core/browser/password_manager_util.cc
index c4ccce1ecf9632625544c58a052e9ee568ec14bd..ef12ebe0d7b2bf5c8c7243b106675d350ae6f218 100644
--- a/components/password_manager/core/browser/password_manager_util.cc
+++ b/components/password_manager/core/browser/password_manager_util.cc
@@ -64,7 +64,7 @@ void TrimUsernameOnlyCredentials(
ScopedVector<autofill::PasswordForm> result;
for (auto& form : *android_credentials) {
if (form->scheme == autofill::PasswordForm::SCHEME_USERNAME_ONLY) {
- if (form->federation_url.is_empty())
+ if (form->federation_origin.unique())
continue;
else
form->skip_zero_click = true;

Powered by Google App Engine
This is Rietveld 408576698