Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1722803002: Sort includes in xfa/. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Sort includes in xfa/. This CL sorts all the includes in the xfa/ directory. There are a lot of IWYU errors that have been fixed to make things compile again. BUG=pdfium:65 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/880962cb81b7a34e4b90a2ecb1992f1afb13d529

Patch Set 1 #

Total comments: 26

Patch Set 2 : Fix windows build #

Patch Set 3 : Review cleanups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1223 lines, -964 lines) Patch
M core/include/fxcrt/fx_basic.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M core/include/fxcrt/fx_memory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M core/include/fxcrt/fx_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/include/foxitxfa.h View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/include/fwl/adapter/fwl_adapterthreadmgr.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M xfa/include/fwl/basewidget/fwl_barcode.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_combobox.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_spinbutton.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_tooltipctrl.h View 2 chunks +4 lines, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_form.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_note.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/include/fwl/core/fwl_widget.h View 1 chunk +5 lines, -1 line 0 comments Download
M xfa/include/fwl/fwl.h View 2 chunks +40 lines, -40 lines 0 comments Download
M xfa/include/fwl/lightwidget/barcode.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/include/fwl/theme/barcodetp.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/include/fwl/theme/carettp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/theme/checkboxtp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/theme/comboboxtp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/theme/datetimepickertp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/theme/edittp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/theme/formtp.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/include/fxfa/fxfa.h View 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/include/fxfa/fxfa_widget.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fdp/include/fde.h View 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/src/fdp/include/fde_css.h View 2 chunks +6 lines, -0 lines 0 comments Download
M xfa/src/fdp/include/fde_img.h View 2 chunks +5 lines, -1 line 0 comments Download
M xfa/src/fdp/include/fde_psr.h View 3 chunks +13 lines, -0 lines 0 comments Download
M xfa/src/fdp/include/fde_rdr.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fdp/include/fde_rdv.h View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa/src/fdp/include/fde_tto.h View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fdp/include/fde_xml.h View 2 chunks +4 lines, -0 lines 0 comments Download
M xfa/src/fdp/src/css/fde_csscache.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fdp/src/css/fde_csscache.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fdp/src/css/fde_cssdatatable.h View 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/src/fdp/src/css/fde_cssdatatable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fdp/src/css/fde_cssdeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fdp/src/css/fde_cssstyleselector.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fdp/src/css/fde_cssstyleselector.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fdp/src/css/fde_cssstylesheet.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fdp/src/css/fde_cssstylesheet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fdp/src/css/fde_csssyntax.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_devbasic.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_devbasic.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fdp/src/fde/fde_gedevice.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_gedevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_geobject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_iterator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_iterator.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fdp/src/fde/fde_object.h View 1 chunk +7 lines, -0 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_object.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fdp/src/fde/fde_render.h View 1 chunk +5 lines, -0 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_render.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fdp/src/tto/fde_textout.h View 1 chunk +12 lines, -0 lines 0 comments Download
M xfa/src/fdp/src/tto/fde_textout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fdp/src/xml/fde_xml_imp.h View 2 chunks +8 lines, -2 lines 0 comments Download
M xfa/src/fdp/src/xml/fde_xml_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fee/include/fx_wordbreak.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fee/include/ifde_txtedtbuf.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fee/include/ifde_txtedtengine.h View 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/src/fee/include/ifde_txtedtpage.h View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtblock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtbuf.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtbuf.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtengine.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtpage.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtparag.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fee/src/fx_wordbreak/fx_wordbreak_impl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M xfa/src/fee/src/fx_wordbreak/fx_wordbreak_impl.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fee/src/fx_wordbreak/fx_wordbreakdata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/include/fgas.h View 1 chunk +9 lines, -9 lines 0 comments Download
M xfa/src/fgas/include/fx_alg.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M xfa/src/fgas/include/fx_cpg.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fgas/include/fx_fnt.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M xfa/src/fgas/include/fx_locale.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fgas/include/fx_mem.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fgas/include/fx_rbk.h View 1 chunk +5 lines, -1 line 0 comments Download
M xfa/src/fgas/include/fx_stm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fgas/include/fx_tbk.h View 2 chunks +4 lines, -0 lines 0 comments Download
M xfa/src/fgas/include/fx_utl.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/crt/fx_memory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fgas/src/crt/fx_memory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/crt/fx_stream.h View 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fgas/src/crt/fx_stream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/crt/fx_utils.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/fgas_base.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/font/fx_gefont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/layout/fx_rtfbreak.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fgas/src/layout/fx_rtfbreak.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/layout/fx_textbreak.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fgas/src/layout/fx_textbreak.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/localization/fx_datetime.cpp View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
M xfa/src/foxitlib.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_caretimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_checkboximp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_formproxyimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_listboximp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_scrollbarimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_spinbuttonimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_tooltipctrlimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_barcodeimp.h View 1 chunk +4 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_caretimp.h View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_checkboximp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_datetimepickerimp.h View 1 chunk +3 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_formproxyimp.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_monthcalendarimp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_pictureboximp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_pushbuttonimp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_scrollbarimp.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_spinbuttonimp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_tooltipctrlimp.h View 1 chunk +4 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_appimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_contentimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_formimp.cpp View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_gridimp.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_noteimp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_panelimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_sdadapterimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/core/fwl_threadimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_timerimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetimp.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_contentimp.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_formimp.h View 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_panelimp.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/tooltipctrl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/widget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_BarCode.cpp View 1 chunk +31 lines, -31 lines 0 comments Download
M xfa/src/fxbarcode/BC_Binarizer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/BC_Binarizer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/BC_BinaryBitmap.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_BinaryBitmap.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.h View 1 chunk +5 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/BC_DecoderResult.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Dimension.h View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Dimension.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Library.cpp View 1 chunk +47 lines, -47 lines 0 comments Download
M xfa/src/fxbarcode/BC_LuminanceSource.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_LuminanceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Reader.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Reader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_ResultPoint.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_ResultPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_TwoDimWriter.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxbarcode/BC_TwoDimWriter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/BC_UtilCodingConvert.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_UtilCodingConvert.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_UtilRSS.h View 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/BC_UtilRSS.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Writer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonCharacterSetECI.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonCharacterSetECI.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonDecoderResult.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonECI.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_GlobalHistogramBinarizer.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_GlobalHistogramBinarizer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_ASCIIEncoder.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_ASCIIEncoder.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_Base256Encoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_Base256Encoder.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_C40Encoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_C40Encoder.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixBitMatrixParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDataBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDecoder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixReader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixSymbolInfo144.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixSymbolInfo144.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixWriter.cpp View 1 chunk +15 lines, -15 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DefaultPlacement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_EdifactEncoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_EdifactEncoder.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_EncoderContext.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_EncoderContext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_ErrorCorrection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_HighLevelEncoder.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_HighLevelEncoder.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_SymbolInfo.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_SymbolInfo.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_TextEncoder.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_X12Encoder.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDReader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDimReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCodaBarWriter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode128Writer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode39Writer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN13Reader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN13Writer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN8Writer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedUPCAReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedUPCAWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BarcodeMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BarcodeValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417CodewordDecoder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417CodewordDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DecodedBitStreamParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResult.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultColumn.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Detector.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectorResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ECErrorCorrection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ECModulusGF.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417HighLevelEncoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417HighLevelEncoder_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Reader.cpp View 1 chunk +19 lines, -19 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Writer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_FinderPatternInfo.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRAlignmentPattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRAlignmentPatternFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRBitMatrixParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCodeReader.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCodeWriter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderDecoder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderEncoder.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderMatrixUtil.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderMode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderVersion.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDataBlock.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDecodedBitStreamParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDetectorResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRFinderPattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRFinderPatternFinder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRGridSampler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_checksum.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffConfigAcc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffapp.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffbarcode.h View 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffbarcode.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffcheckbutton.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffcheckbutton.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffchoicelist.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffchoicelist.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdoc.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdoc.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdochandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdocview.cpp View 1 chunk +18 lines, -18 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdraw.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdraw.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffexclgroup.h View 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffexclgroup.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fffield.h View 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fffield.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffimage.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffimageedit.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffnotify.cpp View 1 chunk +19 lines, -19 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpageview.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpageview.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpath.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpushbutton.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffsignature.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffsubform.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffsubform.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftext.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftextedit.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftextedit.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidget.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgethandler.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fontmgr.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwladapter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwltheme.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_rendercontext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_textlayout.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_common.h View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_docdata.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_doclayout.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_document.h View 2 chunks +4 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_object.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_expression.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_fm2js.h View 1 chunk +14 lines, -14 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_simpleexpression.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_basic_data.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_basic_imp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_datadescription_imp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_datamerger_imp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_imp.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_layout_imp.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_serialize.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_appadapter.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_locale.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_localemgr.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_localevalue.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_object_imp.cpp View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_objectacc_imp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_parser_imp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_datawindow.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_eventpseudomodel.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_hostpseudomodel.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_imp.cpp View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_layoutpseudomodel.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_logpseudomodel.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_signaturepseudomodel.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_utils_imp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxgraphics/src/fx_path_generator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxjse/src/class.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxjse/src/class.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxjse/src/context.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxjse/src/dynprop.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxjse/src/fxv8.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxjse/src/scope_inline.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxjse/src/util_inline.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxjse/src/value.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dsinclair
PTAL. This builds on Mac and Linux. Haven't tried Windows yet as I don't have ...
4 years, 10 months ago (2016-02-22 21:44:12 UTC) #2
dsinclair
Patch set 2 builds on Windows.
4 years, 10 months ago (2016-02-22 22:22:47 UTC) #3
Tom Sepez
LGTM with comments https://codereview.chromium.org/1722803002/diff/1/core/include/fxcrt/fx_basic.h File core/include/fxcrt/fx_basic.h (right): https://codereview.chromium.org/1722803002/diff/1/core/include/fxcrt/fx_basic.h#newcode401 core/include/fxcrt/fx_basic.h:401: typedef CFX_ArrayTemplate<CFX_WideStringC> CFX_WideStringCArray; Put this in ...
4 years, 10 months ago (2016-02-22 22:23:39 UTC) #4
dsinclair
https://codereview.chromium.org/1722803002/diff/1/core/include/fxcrt/fx_basic.h File core/include/fxcrt/fx_basic.h (right): https://codereview.chromium.org/1722803002/diff/1/core/include/fxcrt/fx_basic.h#newcode401 core/include/fxcrt/fx_basic.h:401: typedef CFX_ArrayTemplate<CFX_WideStringC> CFX_WideStringCArray; On 2016/02/22 at 22:23:38, Tom Sepez ...
4 years, 10 months ago (2016-02-23 14:09:15 UTC) #5
dsinclair
4 years, 10 months ago (2016-02-23 14:09:31 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
880962cb81b7a34e4b90a2ecb1992f1afb13d529 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698