xfa/src/fee/include/ifde_txtedtbuf.h - Issue 1722803002: Sort includes in xfa/.

Side by Side Diff: xfa/src/fee/include/ifde_txtedtbuf.h

Issue 1722803002: Sort includes in xfa/. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef XFA_SRC_FEE_INCLUDE_IFDE_TXTEDTBUF_H_	7 #ifndef XFA_SRC_FEE_INCLUDE_IFDE_TXTEDTBUF_H_

8 #define XFA_SRC_FEE_INCLUDE_IFDE_TXTEDTBUF_H_	8 #define XFA_SRC_FEE_INCLUDE_IFDE_TXTEDTBUF_H_

9	9

	10 #include "core/include/fxcrt/fx_basic.h"

	11 #include "core/include/fxcrt/fx_string.h"
	Tom Sepez 2016/02/22 22:23:39 Basic gives you string/system (plus two others). Basic gives you string/system (plus two others). Either include it only, or be more granular about including its includes. dsinclair 2016/02/23 14:09:14 Done. Basic gives IFX_Pause, String gives CFX_Wid Show quoted text On 2016/02/22 at 22:23:39, Tom Sepez wrote: > Basic gives you string/system (plus two others). Either include it only, or be more granular about including its includes. Done. Basic gives IFX_Pause, String gives CFX_WideString and fx_system gives the various types. Shouldn't they all be specified in the header as they're all used?
	12 #include "core/include/fxcrt/fx_system.h"

	13

10 #define FDE_DEFCHUNKLENGTH (1024)	14 #define FDE_DEFCHUNKLENGTH (1024)

11	15

12 class IFDE_TxtEdtBuf {	16 class IFDE_TxtEdtBuf {

13 public:	17 public:

14 virtual ~IFDE_TxtEdtBuf() {}	18 virtual ~IFDE_TxtEdtBuf() {}

15 virtual void Release() = 0;	19 virtual void Release() = 0;

16	20

17 virtual FX_BOOL SetChunkSize(int32_t nChunkSize) = 0;	21 virtual FX_BOOL SetChunkSize(int32_t nChunkSize) = 0;

18 virtual int32_t GetChunkSize() const = 0;	22 virtual int32_t GetChunkSize() const = 0;

19 virtual int32_t GetTextLength() const = 0;	23 virtual int32_t GetTextLength() const = 0;

20 virtual void SetText(const CFX_WideString& wsText) = 0;	24 virtual void SetText(const CFX_WideString& wsText) = 0;

21 virtual void GetText(CFX_WideString& wsText) const = 0;	25 virtual void GetText(CFX_WideString& wsText) const = 0;

22 virtual FX_WCHAR GetCharByIndex(int32_t nIndex) const = 0;	26 virtual FX_WCHAR GetCharByIndex(int32_t nIndex) const = 0;

23 virtual void GetRange(CFX_WideString& wsText,	27 virtual void GetRange(CFX_WideString& wsText,

24 int32_t nBegin,	28 int32_t nBegin,

25 int32_t nCount = -1) const = 0;	29 int32_t nCount = -1) const = 0;

26	30

27 virtual void Insert(int32_t nPos,	31 virtual void Insert(int32_t nPos,

28 const FX_WCHAR* lpText,	32 const FX_WCHAR* lpText,

29 int32_t nLength = 1) = 0;	33 int32_t nLength = 1) = 0;

30 virtual void Delete(int32_t nIndex, int32_t nLength = 1) = 0;	34 virtual void Delete(int32_t nIndex, int32_t nLength = 1) = 0;

31	35

32 virtual void Clear(FX_BOOL bRelease = TRUE) = 0;	36 virtual void Clear(FX_BOOL bRelease = TRUE) = 0;

33	37

34 virtual FX_BOOL Optimize(IFX_Pause* pPause = NULL) = 0;	38 virtual FX_BOOL Optimize(IFX_Pause* pPause = NULL) = 0;

35 };	39 };

36	40

37 #endif // XFA_SRC_FEE_INCLUDE_IFDE_TXTEDTBUF_H_	41 #endif // XFA_SRC_FEE_INCLUDE_IFDE_TXTEDTBUF_H_

OLD	NEW

« xfa/src/fdp/src/xml/fde_xml_imp.h ('K') | « xfa/src/fee/include/fx_wordbreak.h ('k') | xfa/src/fee/include/ifde_txtedtengine.h » ('j') | xfa/src/fgas/include/fx_alg.h » ('J')