Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1722763002: Update bug labels to components in network triage documentation. (Closed)

Created:
4 years, 10 months ago by eroman
Modified:
4 years, 10 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@net_triage_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update bug labels to components in network triage documentation. This follows from the Monorail transition, which separated labels into labels and components. For instance what was previously the label Cr-Internals-Network has become the component Internals>Network Committed: https://crrev.com/962119547765a4df9abc8f31d9a32b14558e2ca1 Cr-Commit-Position: refs/heads/master@{#376805}

Patch Set 1 #

Patch Set 2 : change component: --> component= (so doesn't include subcomponents) #

Total comments: 2

Patch Set 3 : re-wrap long lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -83 lines) Patch
M net/docs/bug-triage.md View 5 chunks +13 lines, -13 lines 0 comments Download
M net/docs/bug-triage-labels.md View 2 chunks +48 lines, -46 lines 0 comments Download
M net/docs/bug-triage-suggested-workflow.md View 1 2 7 chunks +24 lines, -24 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
eroman
https://codereview.chromium.org/1722763002/diff/20001/net/docs/bug-triage-suggested-workflow.md File net/docs/bug-triage-suggested-workflow.md (right): https://codereview.chromium.org/1722763002/diff/20001/net/docs/bug-triage-suggested-workflow.md#newcode114 net/docs/bug-triage-suggested-workflow.md:114: mark it with component Privacy. Kind of weird, but ...
4 years, 10 months ago (2016-02-22 19:22:31 UTC) #2
mmenke
LGTM. Just skimmed the changes. https://codereview.chromium.org/1722763002/diff/20001/net/docs/bug-triage-suggested-workflow.md File net/docs/bug-triage-suggested-workflow.md (right): https://codereview.chromium.org/1722763002/diff/20001/net/docs/bug-triage-suggested-workflow.md#newcode114 net/docs/bug-triage-suggested-workflow.md:114: mark it with component ...
4 years, 10 months ago (2016-02-22 19:28:01 UTC) #3
eroman
As an aside: I have updated this CL's description to be more informative.
4 years, 10 months ago (2016-02-22 19:32:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722763002/40001
4 years, 10 months ago (2016-02-22 20:28:08 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-22 21:42:14 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 21:43:54 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/962119547765a4df9abc8f31d9a32b14558e2ca1
Cr-Commit-Position: refs/heads/master@{#376805}

Powered by Google App Engine
This is Rietveld 408576698