Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Side by Side Diff: net/docs/bug-triage-labels.md

Issue 1722763002: Update bug labels to components in network triage documentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@net_triage_1
Patch Set: re-wrap long lines Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/docs/bug-triage.md ('k') | net/docs/bug-triage-suggested-workflow.md » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Chrome Network Bug Triage : Labels 1 # Chrome Network Bug Triage : Components and labels
2 2
3 ## Some network label caveats 3 ## Some network component caveats
4 4
5 **Cr-UI-Browser-Downloads** 5 **UI>Browser>Downloads**
6 : Despite the name, this covers all issues related to downloading a file except 6 : Despite the name, this covers all issues related to downloading a file except
7 saving entire pages (which is **Cr-Blink-SavePage**), not just UI issues. 7 saving entire pages (which is **Blink>SavePage**), not just UI issues.
8 Most downloads bugs will have the word "download" or "save as" in the 8 Most downloads bugs will have the word "download" or "save as" in the
9 description. Issues with the HTTP server for the Chrome binaries are not 9 description. Issues with the HTTP server for the Chrome binaries are not
10 downloads bugs. 10 downloads bugs.
11 11
12 **Cr-UI-Browser-SafeBrowsing** 12 **UI>Browser>SafeBrowsing**
13 : Bugs that have to do with the process by which a URL or file is determined to 13 : Bugs that have to do with the process by which a URL or file is determined to
14 be dangerous based on our databases, or the resulting interstitials. 14 be dangerous based on our databases, or the resulting interstitials.
15 Determination of danger based purely on content-type or file extension 15 Determination of danger based purely on content-type or file extension
16 belongs in **Cr-UI-Browser-Downloads**, not SafeBrowsing. 16 belongs in **UI>Browser>Downloads**, not SafeBrowsing.
17 17
18 **Cr-Internals-Network-SSL** 18 **Internals>Network>SSL**
19 : This includes issues that should be also tagged as **Cr-Security-UX** 19 : This includes issues that should be also tagged as **Security>UX**
20 (certificate error pages or other security interstitials, omnibox indicators 20 (certificate error pages or other security interstitials, omnibox indicators
21 that a page is secure), and more general SSL issues. If you see requests 21 that a page is secure), and more general SSL issues. If you see requests
22 that die in the SSL negotiation phase, in particular, this is often the 22 that die in the SSL negotiation phase, in particular, this is often the
23 correct label. 23 correct component.
24 24
25 **Cr-Internals-Network-DataProxy** 25 **Internals>Network>DataProxy**
26 : Flywheel / the Data Reduction Proxy. Issues require "Reduce Data Usage" be 26 : Flywheel / the Data Reduction Proxy. Issues require "Reduce Data Usage" be
27 turned on. Proxy url is [https://proxy.googlezip.net:443](), with 27 turned on. Proxy url is [https://proxy.googlezip.net:443](), with
28 [http://compress.googlezip.net:80]() as a fallback. Currently Android and 28 [http://compress.googlezip.net:80]() as a fallback. Currently Android and
29 iOS only. 29 iOS only.
30 30
31 **Cr-Internals-Network-Cache** 31 **Internals>Network>Cache**
32 : The cache is the layer that handles most range request logic (Though range 32 : The cache is the layer that handles most range request logic (Though range
33 requests may also be issued by the PDF plugin, XHRs, or other components). 33 requests may also be issued by the PDF plugin, XHRs, or other components).
34 34
35 **Cr-Internals-Network-SPDY** 35 **Internals>Network>SPDY**
36 : Covers HTTP2 as well. 36 : Covers HTTP2 as well.
37 37
38 **Cr-Internals-Network-HTTP** 38 **Internals>Network>HTTP**
39 : Typically not used. Unclear what it covers, and there's no specific HTTP 39 : Typically not used. Unclear what it covers, and there's no specific HTTP
40 owner. 40 owner.
41 41
42 **Cr-Internals-Network-Logging** 42 **Internals>Network>Logging**
43 : Covers **about:net-internals**, **about:net-export** as well as the what's 43 : Covers **about:net-internals**, **about:net-export** as well as the what's
44 sent to the NetLog. 44 sent to the NetLog.
45 45
46 **Cr-Internals-Network-Connectivity** 46 **Internals>Network>Connectivity**
47 : Issues related to switching between networks, ERR_NETWORK_CHANGED, Chrome 47 : Issues related to switching between networks, ERR_NETWORK_CHANGED, Chrome
48 thinking it's online when it's not / navigator.onLine inaccuracies, etc. 48 thinking it's online when it's not / navigator.onLine inaccuracies, etc.
49 49
50 **Cr-Internals-Network-Filters** 50 **Internals>Network>Filters**
51 : Covers SDCH and gzip issues. ERR_CONTENT_DECODING_FAILED indicates a problem 51 : Covers SDCH and gzip issues. ERR_CONTENT_DECODING_FAILED indicates a problem
52 at this layer, and bugs here can also cause response body corruption. 52 at this layer, and bugs here can also cause response body corruption.
53 53
54 ## Common non-network labels 54 ## Common non-network components
55 55
56 Bugs in these areas often receive the **Cr-Internals-Network** label, though 56 Bugs in these areas often receive the **Internals>Network** component, though
57 they fall largely outside the purview of the network stack team: 57 they fall largely outside the purview of the network stack team:
58 58
59 **Cr-Blink-Forms** 59 **Blink>Forms**
60 : Issues submitting forms, forms having weird data, forms sending the wrong 60 : Issues submitting forms, forms having weird data, forms sending the wrong
61 method, etc. 61 method, etc.
62 62
63 **Cr-Blink-Loader** 63 **Blink>Loader**
64 : Cross origin issues are sometimes loader related. Blink also has an 64 : Cross origin issues are sometimes loader related. Blink also has an
65 in-memory cache, and when it's used, requests don't appear in 65 in-memory cache, and when it's used, requests don't appear in
66 about:net-internals. Requests for the same URL are also often merged there 66 about:net-internals. Requests for the same URL are also often merged there
67 as well. This does *not* cover issues with content/browser/loader/ files. 67 as well. This does *not* cover issues with content/browser/loader/ files.
68 68
69 **Cr-Blink-ServiceWorker** 69 **Blink>ServiceWorker**
70 70
71 **Cr-Blink-Storage-AppCache** 71 **Blink>Storage>AppCache**
72 72
73 **Cr-Blink-Network-WebSockets** 73 **Blink>Network>WebSockets**
74 : Issues with the WebSockets. Attach this label to any issue about the 74 : Issues with the WebSockets. Attach this component to any issue about the
75 WebSocket feature regardless of where the cause of the issue is (net/ or 75 WebSocket feature regardless of where the cause of the issue is (net/ or
76 Blink). 76 Blink).
77 77
78 **Cr-Blink-Network-FetchAPI** 78 **Blink>Network>FetchAPI**
79 : Generic issues with the Fetch API - missing request or response 79 : Generic issues with the Fetch API - missing request or response
80 headers, multiple headers, etc. These will often run into issues in certain 80 headers, multiple headers, etc. These will often run into issues in certain
81 corner cases (Cross origin / CORS, proxy, whatever). Attach all labels that 81 corner cases (Cross origin / CORS, proxy, whatever). Attach all components th at
82 seem appropriate. 82 seem appropriate.
83 83
84 **Cr-Blink-Network-XHR** 84 **Blink>Network>XHR**
85 : Generic issues with sync/async XHR requests. 85 : Generic issues with sync/async XHR requests.
86 86
87 **Cr-Services-Sync** 87 **Services>Sync**
88 : Sharing data/tabs/history/passwords/etc between machines not working. 88 : Sharing data/tabs/history/passwords/etc between machines not working.
89 89
90 **Cr-Services-Chromoting** 90 **Services>Chromoting**
91 91
92 **Cr-Platform-Extensions** 92 **Platform>Extensions**
93 : Issues extensions loading / not loading / hanging. 93 : Issues extensions loading / not loading / hanging.
94 94
95 **Cr-Platform-Extensions-API** 95 **Platform>Extensions>API**
96 : Issues with network related extension APIs should have this label. 96 : Issues with network related extension APIs should have this component.
97 chrome.webRequest is the big one, I believe, but there are others. 97 chrome.webRequest is the big one, I believe, but there are others.
98 98
99 **Cr-Internals-Plugins-Pepper[-SDK]** 99 **Internals>Plugins>Pepper[>SDK]**
100 100
101 **Cr-UI-Browser-Omnibox** 101 **UI>Browser>Omnibox**
102 : Basically any issue with the omnibox. URLs being treated as search queries 102 : Basically any issue with the omnibox. URLs being treated as search queries
103 rather than navigations, dropdown results being weird, not handling certain 103 rather than navigations, dropdown results being weird, not handling certain
104 unicode characters, etc. If the issue is new TLDs not being recognized by 104 unicode characters, etc. If the issue is new TLDs not being recognized by
105 the omnibox, that's due to Chrome's TLD list being out of date, and not an 105 the omnibox, that's due to Chrome's TLD list being out of date, and not an
106 omnibox issue. Such TLD issues should be duped against 106 omnibox issue. Such TLD issues should be duped against
107 http://crbug.com/37436. 107 http://crbug.com/37436.
108 108
109 **Cr-Internals-Media-Network** 109 **Internals>Media>Network**
110 : Issues related to media. These often run into the 6 requests per hostname 110 : Issues related to media. These often run into the 6 requests per hostname
111 issue, and also have fun interactions with the cache, particularly in the 111 issue, and also have fun interactions with the cache, particularly in the
112 range request case. 112 range request case.
113 113
114 **Cr-Internals-Plugins-PDF** 114 **Internals>Plugins>PDF**
115 : Issues loading pdf files. These are often related to range requests, which 115 : Issues loading pdf files. These are often related to range requests, which
116 also have some logic at the Internals-Network-Cache layer. 116 also have some logic at the Internals>Network>Cache layer.
117 117
118 **Cr-UI-Browser-Navigation** 118 **UI>Browser>Navigation**
119 119
120 **Cr-UI-Browser-History** 120 **UI>Browser>History**
121 : Issues which only appear with forward/back navigation. 121 : Issues which only appear with forward/back navigation.
122 122
123 **Cr-OS-Systems-Network** / **Cr-OS-Systems-Mobile** / **Cr-OS-Systems-Bluetooth ** 123 **OS>Systems>Network** / **OS>Systems>Mobile** / **OS>Systems>Bluetooth**
124 : These should be used for issues with ChromeOS's platform network code, and 124 : These should be used for issues with ChromeOS's platform network code, and
125 not net/ issues on ChromeOS. 125 not net/ issues on ChromeOS.
126 126
127 **Cr-Blink-SecurityFeature** 127 **Blink>SecurityFeature**
128 : CORS / Cross origin issues. Main frame cross-origin navigation issues are 128 : CORS / Cross origin issues. Main frame cross-origin navigation issues are
129 often actually **Cr-UI-Browser-Navigation** issues. 129 often actually **UI>Browser>Navigation** issues.
130 130
131 **Cr-Privacy** 131 **Privacy**
132 : Privacy related bug (History, cookies discoverable by an entity that 132 : Privacy related bug (History, cookies discoverable by an entity that
133 shouldn't be able to do so, incognito state being saved in memory or on disk 133 shouldn't be able to do so, incognito state being saved in memory or on disk
134 beyond the lifetime of incognito tabs, etc). Generally used in conjunction 134 beyond the lifetime of incognito tabs, etc). Generally used in conjunction
135 with other labels. 135 with other components.
136
137 ## Common labels
136 138
137 **Type-Bug-Security** 139 **Type-Bug-Security**
138 : Security related bug (Allows for code execution from remote site, allows 140 : Security related bug (Allows for code execution from remote site, allows
139 crossing security boundaries, unchecked array bounds, 141 crossing security boundaries, unchecked array bounds, etc) should be tagged
140 etc). 142 with this label.
OLDNEW
« no previous file with comments | « net/docs/bug-triage.md ('k') | net/docs/bug-triage-suggested-workflow.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698