Project Eraser: Kill chrome://memory.

Project Eraser: Kill chrome://memory.

This deletes the majority of the code supporting chrome://memory
pages. There's still a little bit more of follow-up work to clean up
memory_details*.cc files, but those will require some changes to logic
and thus is better to do them in a separate CL.

BUG=588790, 25454
Committed: https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a
Cr-Commit-Position: refs/heads/master@{#382198}

[Alexei Svitkine (slow), 2016-02-22 19:04:15]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2016-02-22 19:15:59]

Description was changed from

==========
Kill chrome://memory.

BUG=TBD
==========

to

==========
Kill chrome://memory.

See bug for details.

BUG=588790,25454
==========

[Alexei Svitkine (slow), 2016-02-22 19:20:39]

Description was changed from

==========
Kill chrome://memory.

See bug for details.

BUG=588790,25454
==========

to

==========
Kill chrome://memory.

This deletes the majority of the code supporting chrome://memory pages. There's
still a little bit more of follow-up work to clean up
memory_details*.cc files, but those will require some changes to logic
and thus is better to do them in a separate CL.

BUG=588790,25454
==========

[Alexei Svitkine (slow), 2016-02-22 19:20:51]

Description was changed from

==========
Kill chrome://memory.

This deletes the majority of the code supporting chrome://memory pages. There's
still a little bit more of follow-up work to clean up
memory_details*.cc files, but those will require some changes to logic
and thus is better to do them in a separate CL.

BUG=588790,25454
==========

to

==========
Kill chrome://memory.

This deletes the majority of the code supporting chrome://memory
pages. There's still a little bit more of follow-up work to clean up
memory_details*.cc files, but those will require some changes to logic
and thus is better to do them in a separate CL.

BUG=588790,25454
==========

[Alexei Svitkine (slow), 2016-02-22 19:21:22]

Description was changed from

==========
Kill chrome://memory.

This deletes the majority of the code supporting chrome://memory
pages. There's still a little bit more of follow-up work to clean up
memory_details*.cc files, but those will require some changes to logic
and thus is better to do them in a separate CL.

BUG=588790,25454
==========

to

==========
Project Eraser: Kill chrome://memory.

This deletes the majority of the code supporting chrome://memory
pages. There's still a little bit more of follow-up work to clean up
memory_details*.cc files, but those will require some changes to logic
and thus is better to do them in a separate CL.

BUG=588790,25454
==========

[Alexei Svitkine (slow), 2016-02-22 19:22:01]

asvitkine@chromium.org changed reviewers:
+ thestig@chromium.org

[Alexei Svitkine (slow), 2016-02-22 19:22:02]

thestig: PTAL

Note: I still need to fix up the .xib file (need to save it on 10.9 :\), but
otherwise I think this change should be good to go.

[Alexei Svitkine (slow), 2016-02-22 19:24:42]

thestig: PTAL

Note: I still need to fix up the .xib file (need to save it on 10.9 :\), but
otherwise I think this change should be ready for reviewed. Thanks.

[Lei Zhang, 2016-02-22 19:58:16]

+peria who is in the OWNERS files being removed.

Has a decision been made on removing this?

[Lei Zhang, 2016-02-22 20:04:32]

Code looks ok. Not sure if the unrelated changes in
chrome/app/nibs/TaskManager.xib should be there.

[Alexei Svitkine (slow), 2016-02-22 20:15:45]

Yep, let me cc you to the thread.
On 22 Feb 2016 11:58 a.m., <thestig@chromium.org> wrote:

> +peria who is in the OWNERS files being removed.
>
> Has a decision been made on removing this?
>
> https://codereview.chromium.org/1722493002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2016-02-22 20:22:45]

Yeah, as I mentioned - I need to make the changes to the xib file on 10.9.
So will not land the CL until I make those changes.

On Mon, Feb 22, 2016 at 12:15 PM, Alexei Svitkine <asvitkine@chromium.org>
wrote:

> Yep, let me cc you to the thread.
> On 22 Feb 2016 11:58 a.m., <thestig@chromium.org> wrote:
>
>> +peria who is in the OWNERS files being removed.
>>
>> Has a decision been made on removing this?
>>
>> https://codereview.chromium.org/1722493002/
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[peria, 2016-02-26 05:48:51]

On 2016/02/22 19:58:16, Lei Zhang wrote:
> +peria who is in the OWNERS files being removed.
> 
> Has a decision been made on removing this?

Yes, I agreed.

[Alexei Svitkine (slow), 2016-03-14 15:06:41]

thestig: Now that you're hopefully back from vacation, friendly ping.

[Lei Zhang, 2016-03-18 20:17:04]

lgtm

[Alexei Svitkine (slow), 2016-03-18 20:22:25]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2016-03-18 20:22:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722493002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722493002/80001

[Alexei Svitkine (slow), 2016-03-18 20:23:47]

The CQ bit was unchecked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-03-18 20:25:13]

asvitkine@chromium.org changed reviewers:
+ avi@chromium.org

[Alexei Svitkine (slow), 2016-03-18 20:26:13]

asvitkine@chromium.org changed reviewers:
+ sdefresne@chromium.org

[Alexei Svitkine (slow), 2016-03-18 20:26:13]

+avi for content/
+sdefresne for ios/ and components/history

[Avi (use Gerrit), 2016-03-18 20:32:41]

lgtm

[sdefresne, 2016-03-19 13:25:49]

ios/ and components/history/ lgtm

[Alexei Svitkine (slow), 2016-03-19 14:10:02]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-03-19 14:10:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1722493002/#ps100001
(title: "Fix chrome_browser_ui.gypi.")

[commit-bot: I haz the power, 2016-03-19 14:10:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722493002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722493002/100001

[commit-bot: I haz the power, 2016-03-19 14:18:16]

Description was changed from

==========
Project Eraser: Kill chrome://memory.

This deletes the majority of the code supporting chrome://memory
pages. There's still a little bit more of follow-up work to clean up
memory_details*.cc files, but those will require some changes to logic
and thus is better to do them in a separate CL.

BUG=588790,25454
==========

to

==========
Project Eraser: Kill chrome://memory.

This deletes the majority of the code supporting chrome://memory
pages. There's still a little bit more of follow-up work to clean up
memory_details*.cc files, but those will require some changes to logic
and thus is better to do them in a separate CL.

BUG=588790,25454
==========

[commit-bot: I haz the power, 2016-03-19 14:18:18]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-03-19 14:19:32]

Description was changed from

==========
Project Eraser: Kill chrome://memory.

This deletes the majority of the code supporting chrome://memory
pages. There's still a little bit more of follow-up work to clean up
memory_details*.cc files, but those will require some changes to logic
and thus is better to do them in a separate CL.

BUG=588790,25454
==========

to

==========
Project Eraser: Kill chrome://memory.

This deletes the majority of the code supporting chrome://memory
pages. There's still a little bit more of follow-up work to clean up
memory_details*.cc files, but those will require some changes to logic
and thus is better to do them in a separate CL.

BUG=588790,25454

Committed: https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a
Cr-Commit-Position: refs/heads/master@{#382198}
==========

[commit-bot: I haz the power, 2016-03-19 14:19:33]

Patchset 5 (id:??) landed as
https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a
Cr-Commit-Position: refs/heads/master@{#382198}