Project Eraser: Kill chrome://memory.

chrome/browser/memory_details.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/memory_details.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/bind.h"
 #include "base/file_version_info.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/profiles/profile.h"
-#include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/nacl/common/nacl_process_type.h"
 #include "components/strings/grit/components_strings.h"
 #include "content/public/browser/browser_child_process_host_iterator.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/child_process_data.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
@@ skipping 55 matching lines @@
     int process_type,
     RendererProcessType rtype) {
   if (process_type == content::PROCESS_TYPE_RENDERER)
     return GetRendererTypeNameInEnglish(rtype);
   return content::GetProcessTypeNameInEnglish(process_type);
 }
 
 ProcessMemoryInformation::ProcessMemoryInformation()
     : pid(0),
       num_processes(0),
-      is_diagnostics(false),
       process_type(content::PROCESS_TYPE_UNKNOWN),
       renderer_type(RENDERER_UNKNOWN) {
 }
 
 ProcessMemoryInformation::ProcessMemoryInformation(
     const ProcessMemoryInformation& other) = default;
 
 ProcessMemoryInformation::~ProcessMemoryInformation() {}
 
 bool ProcessMemoryInformation::operator<(
@@ skipping 222 matching lines @@
         process.renderer_type =
             ProcessMemoryInformation::RENDERER_BACKGROUND_APP;
         continue;
       }
 #endif
 
       base::string16 title = contents->GetTitle();
       if (!title.length())
         title = l10n_util::GetStringUTF16(IDS_DEFAULT_TAB_TITLE);
       process.titles.push_back(title);
-
-      // The presence of a single WebContents with a diagnostics page will make
-      // the whole process be considered a diagnostics process.
-      //
-      // We need to check the pending entry as well as the virtual_url to
-      // see if it's a chrome://memory URL (we don't want to count these in
-      // the total memory usage of the browser).
-      //
-      // When we reach here, chrome://memory will be the pending entry since
-      // we haven't responded with any data such that it would be committed.
-      // If you have another chrome://memory tab open (which would be
-      // committed), we don't want to count it either, so we also check the
-      // last committed entry.
-      //
-      // Either the pending or last committed entries can be NULL.
-      const NavigationEntry* pending_entry =
-          contents->GetController().GetPendingEntry();
-      const NavigationEntry* last_committed_entry =
-          contents->GetController().GetLastCommittedEntry();
-      if ((last_committed_entry &&
-           base::LowerCaseEqualsASCII(
-               last_committed_entry->GetVirtualURL().spec(),
-               chrome::kChromeUIMemoryURL)) ||
-          (pending_entry &&
-           base::LowerCaseEqualsASCII(
-               pending_entry->GetVirtualURL().spec(),
-               chrome::kChromeUIMemoryURL))) {
-        process.is_diagnostics = true;
-      }
     }
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_ANDROID)
     if (content::ZygoteHost::GetInstance()->IsZygotePid(process.pid)) {
       process.process_type = content::PROCESS_TYPE_ZYGOTE;
     }
 #endif
   }
 
   // Get rid of other Chrome processes that are from a different profile.
   auto is_unknown = [](ProcessMemoryInformation& process) {
     return process.process_type == content::PROCESS_TYPE_UNKNOWN;
   };
   auto& vector = chrome_browser->processes;
   vector.erase(std::remove_if(vector.begin(), vector.end(), is_unknown),
                vector.end());
 
   OnDetailsAvailable();
 }