content/browser/child_process_security_policy_unittest.cc - Issue 1722493002: Project Eraser: Kill chrome://memory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/child_process_security_policy_unittest.cc

Issue 1722493002: Project Eraser: Kill chrome://memory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chrome_browser_ui.gypi. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/child_process_security_policy_unittest.cc

diff --git a/content/browser/child_process_security_policy_unittest.cc b/content/browser/child_process_security_policy_unittest.cc

index 23604683ad3b085552dc3e334b6abaab9336f3fe..455da447dd306ef0e36f1fb473535f8f3b856f77 100644

--- a/content/browser/child_process_security_policy_unittest.cc

+++ b/content/browser/child_process_security_policy_unittest.cc

@@ -203,21 +203,22 @@ TEST_F(ChildProcessSecurityPolicyTest, AboutTest) {

EXPECT_TRUE(p->CanCommitURL(kRendererID, GURL("aBouT:BlAnK")));

EXPECT_TRUE(p->CanCommitURL(kRendererID, GURL("aBouT:blank")));

- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:memory")));

EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:crash")));

EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:cache")));

EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:hang")));

- EXPECT_FALSE(p->CanCommitURL(kRendererID, GURL("about:memory")));

+ EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:version")));

EXPECT_FALSE(p->CanCommitURL(kRendererID, GURL("about:crash")));

EXPECT_FALSE(p->CanCommitURL(kRendererID, GURL("about:cache")));

EXPECT_FALSE(p->CanCommitURL(kRendererID, GURL("about:hang")));

+ EXPECT_FALSE(p->CanCommitURL(kRendererID, GURL("about:version")));

- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("aBoUt:memory")));

+ EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("aBoUt:version")));

EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:CrASh")));

EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("abOuT:cAChe")));

- EXPECT_FALSE(p->CanCommitURL(kRendererID, GURL("aBoUt:memory")));

+ EXPECT_FALSE(p->CanCommitURL(kRendererID, GURL("aBoUt:version")));

EXPECT_FALSE(p->CanCommitURL(kRendererID, GURL("about:CrASh")));

EXPECT_FALSE(p->CanCommitURL(kRendererID, GURL("abOuT:cAChe")));

+ EXPECT_FALSE(p->CanCommitURL(kRendererID, GURL("aBoUt:version")));

// Requests for about: pages should be denied.

p->GrantRequestURL(kRendererID, GURL("about:crash"));