Add cap and builder feature for multisample interpolation

Add cap and builder feature for multisample interpolation

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722363002

Committed: https://skia.googlesource.com/skia/+/4a98cdb7612493a062358cebd1141c9bcaa37ab1

[Chris Dalton, 2016-02-23 20:22:57]

Description was changed from

==========
Add support for multisample interpolation

Adds caps and builder methods to facilitate interpolation at sample
locations in fragment processors.

BUG=skia:
==========

to

==========
Add support for multisample interpolation

Adds caps and builder methods to facilitate interpolation at sample
locations in fragment processors.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Chris Dalton, 2016-02-23 20:28:06]

cdalton@nvidia.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[Chris Dalton, 2016-02-23 20:28:06]

Uploading this change now since it can help illustrate the use for sample
locations.

[Chris Dalton, 2016-02-29 20:58:16]

Description was changed from

==========
Add support for multisample interpolation

Adds caps and builder methods to facilitate interpolation at sample
locations in fragment processors.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add cap and builder feature for multisample interpolation

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Chris Dalton, 2016-02-29 20:59:04]

cdalton@nvidia.com changed reviewers:
+ egdaniel@google.com

[Chris Dalton, 2016-02-29 20:59:05]

This one is really simple now

[joshualitt, 2016-03-01 17:58:58]

question for Brian

https://codereview.chromium.org/1722363002/diff/20001/src/gpu/glsl/GrGLSLCaps...
File src/gpu/glsl/GrGLSLCaps.cpp (right):

https://codereview.chromium.org/1722363002/diff/20001/src/gpu/glsl/GrGLSLCaps...
src/gpu/glsl/GrGLSLCaps.cpp:72: r.appendf("Multisample interpolation support:
%s\n", (fMultisampleInterpolationSupport ?
Should we log the string? we don't do it for fb fetch support, but we do seem to
do it for kAdvBlendEqInteractionStr

[bsalomon, 2016-03-01 18:02:26]

otherwise lgtm

https://codereview.chromium.org/1722363002/diff/20001/src/gpu/glsl/GrGLSLCaps...
File src/gpu/glsl/GrGLSLCaps.cpp (right):

https://codereview.chromium.org/1722363002/diff/20001/src/gpu/glsl/GrGLSLCaps...
src/gpu/glsl/GrGLSLCaps.cpp:72: r.appendf("Multisample interpolation support:
%s\n", (fMultisampleInterpolationSupport ?
On 2016/03/01 17:58:58, joshualitt wrote:
> Should we log the string? we don't do it for fb fetch support, but we do seem
to
> do it for kAdvBlendEqInteractionStr

Seems like it'd be nice to log both.

[joshualitt, 2016-03-01 18:02:46]

https://codereview.chromium.org/1722363002/diff/20001/src/gpu/glsl/GrGLSLCaps...
File src/gpu/glsl/GrGLSLCaps.cpp (right):

https://codereview.chromium.org/1722363002/diff/20001/src/gpu/glsl/GrGLSLCaps...
src/gpu/glsl/GrGLSLCaps.cpp:72: r.appendf("Multisample interpolation support:
%s\n", (fMultisampleInterpolationSupport ?
On 2016/03/01 17:58:58, joshualitt wrote:
> Should we log the string? we don't do it for fb fetch support, but we do seem
to
> do it for kAdvBlendEqInteractionStr

whoops, should have paid more attention, the string is either a nullptr or
"GL_OES_shader_multisample_interpolation", nvm

[bsalomon, 2016-03-01 18:03:50]

On 2016/03/01 18:02:46, joshualitt wrote:
>
https://codereview.chromium.org/1722363002/diff/20001/src/gpu/glsl/GrGLSLCaps...
> File src/gpu/glsl/GrGLSLCaps.cpp (right):
> 
>
https://codereview.chromium.org/1722363002/diff/20001/src/gpu/glsl/GrGLSLCaps...
> src/gpu/glsl/GrGLSLCaps.cpp:72: r.appendf("Multisample interpolation support:
> %s\n", (fMultisampleInterpolationSupport ?
> On 2016/03/01 17:58:58, joshualitt wrote:
> > Should we log the string? we don't do it for fb fetch support, but we do
seem
> to
> > do it for kAdvBlendEqInteractionStr
> 
> whoops, should have paid more attention, the string is either a nullptr or
> "GL_OES_shader_multisample_interpolation", nvm

Sure, let's leave it out.

[Chris Dalton, 2016-03-01 19:40:39]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2016-03-01 19:40:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722363002/20001

[commit-bot: I haz the power, 2016-03-01 20:12:23]

Description was changed from

==========
Add cap and builder feature for multisample interpolation

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add cap and builder feature for multisample interpolation

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/4a98cdb7612493a062358cebd1141c9bcaa37ab1
==========

[commit-bot: I haz the power, 2016-03-01 20:12:24]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4a98cdb7612493a062358cebd1141c9bcaa37ab1