Added UMA collection for fullscreen / mouse lock bubble re-shows.

Added UMA collection for fullscreen / mouse lock bubble re-shows.

During a fullscreen / mouse lock session, it collects data about the
total number of times the bubble is re-shown due to input timeout. At
the end of the session, it logs the count to UMA.

BUG=585354
Committed: https://crrev.com/d1e6fe94b6268034c6f127f11f044ca949b4fdbf
Cr-Commit-Position: refs/heads/master@{#377516}

[Matt Giuca, 2016-02-22 06:23:31]

mgiuca@chromium.org changed reviewers:
+ dominickn@chromium.org

[Matt Giuca, 2016-02-22 06:23:32]

dominickn for initial review. Thanks!

[Matt Giuca, 2016-02-22 06:24:09]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 06:24:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1721633002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1721633002/1

[commit-bot: I haz the power, 2016-02-22 06:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 06:34:55]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dominickn, 2016-02-23 00:05:27]

https://codereview.chromium.org/1721633002/diff/1/chrome/browser/ui/exclusive...
File chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc
(right):

https://codereview.chromium.org/1721633002/diff/1/chrome/browser/ui/exclusive...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc:79:
histogram_name += "BubbleReshowsPerSession";
Nit: Please rename this to
ExclusiveAccess.BubbleReshowsPerSession.(Fullscreen|Mouselock) so that it's one
less concatenation here.

https://codereview.chromium.org/1721633002/diff/1/chrome/browser/ui/exclusive...
File chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
(right):

https://codereview.chromium.org/1721633002/diff/1/chrome/browser/ui/exclusive...
chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc:499:
histogram_tester.ExpectUniqueSample(kFullscreenReshowHistogramName, 0, 1);
Nit: is there a test that reshows the bubble so you can check samples go into
the histogram? Or can you add a test that manually triggers the bubble?

[Matt Giuca, 2016-02-23 02:50:28]

https://codereview.chromium.org/1721633002/diff/1/chrome/browser/ui/exclusive...
File chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc
(right):

https://codereview.chromium.org/1721633002/diff/1/chrome/browser/ui/exclusive...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc:79:
histogram_name += "BubbleReshowsPerSession";
On 2016/02/23 00:05:27, dominickn wrote:
> Nit: Please rename this to
> ExclusiveAccess.BubbleReshowsPerSession.(Fullscreen|Mouselock) so that it's
one
> less concatenation here.

Done.

https://codereview.chromium.org/1721633002/diff/1/chrome/browser/ui/exclusive...
File chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
(right):

https://codereview.chromium.org/1721633002/diff/1/chrome/browser/ui/exclusive...
chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc:499:
histogram_tester.ExpectUniqueSample(kFullscreenReshowHistogramName, 0, 1);
On 2016/02/23 00:05:27, dominickn wrote:
> Nit: is there a test that reshows the bubble so you can check samples go into
> the histogram? Or can you add a test that manually triggers the bubble?

No, there isn't. I tried writing some minimal tests yesterday but I think we
just need to start a brand new unit test from scratch.

These "unit tests" are extremely heavyweight and involve spinning up a browser
window. I would have to simulate mouse movements, timers, etc. I don't really
want to add more of these. I just want a simple unit test around
FullscreenController, but there isn't one.

At least for now this shows that we record to the histogram. I plan to add
comprehensive unit tests for the exclusive access classes in the future, and
this will be included there.

[Matt Giuca, 2016-02-23 02:50:37]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 02:51:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1721633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1721633002/40001

[dominickn, 2016-02-23 03:05:54]

Initial review lgtm % nit

https://codereview.chromium.org/1721633002/diff/1/chrome/browser/ui/exclusive...
File chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
(right):

https://codereview.chromium.org/1721633002/diff/1/chrome/browser/ui/exclusive...
chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc:499:
histogram_tester.ExpectUniqueSample(kFullscreenReshowHistogramName, 0, 1);
On 2016/02/23 02:50:28, Matt Giuca wrote:
> On 2016/02/23 00:05:27, dominickn wrote:
> > Nit: is there a test that reshows the bubble so you can check samples go
into
> > the histogram? Or can you add a test that manually triggers the bubble?
> 
> No, there isn't. I tried writing some minimal tests yesterday but I think we
> just need to start a brand new unit test from scratch.
> 
> These "unit tests" are extremely heavyweight and involve spinning up a browser
> window. I would have to simulate mouse movements, timers, etc. I don't really
> want to add more of these. I just want a simple unit test around
> FullscreenController, but there isn't one.
> 
> At least for now this shows that we record to the histogram. I plan to add
> comprehensive unit tests for the exclusive access classes in the future, and
> this will be included there.

Acknowledged.

https://codereview.chromium.org/1721633002/diff/40001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc
(right):

https://codereview.chromium.org/1721633002/diff/40001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc:77:
std::string histogram_name = "ExclusiveAccess.BubbleReshowsPerSession.";
Nit: should this be a constant in the anonymous namespace?

[commit-bot: I haz the power, 2016-02-23 04:34:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 04:34:54]

Dry run: This issue passed the CQ dry run.

[Matt Giuca, 2016-02-23 04:37:01]

https://codereview.chromium.org/1721633002/diff/40001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc
(right):

https://codereview.chromium.org/1721633002/diff/40001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc:77:
std::string histogram_name = "ExclusiveAccess.BubbleReshowsPerSession.";
On 2016/02/23 03:05:54, dominickn wrote:
> Nit: should this be a constant in the anonymous namespace?

Done.

[Matt Giuca, 2016-02-23 04:37:49]

mgiuca@chromium.org changed reviewers:
+ isherman@chromium.org, scheib@chromium.org

[Matt Giuca, 2016-02-23 04:37:50]

scheib: OWNERS on c/b/u/exclusive_access
isherman: OWNERS on histograms.xml

Thanks.

[Matt Giuca, 2016-02-23 04:42:25]

Description was changed from

==========
Added UMA collection for fullscreen / mouse lock bubble re-shows.

During a fullscreen / mouse lock session, it collects data about the
total number of times the bubble is re-shown due to input timeout. At
the end of the session, it logs the count to UMA.


BUG=585354
==========

to

==========
Added UMA collection for fullscreen / mouse lock bubble re-shows.

During a fullscreen / mouse lock session, it collects data about the
total number of times the bubble is re-shown due to input timeout. At
the end of the session, it logs the count to UMA.

BUG=585354
==========

[scheib, 2016-02-23 23:52:26]

LGTM with renames/comments:

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/exclusive_access_bubble.cc (right):

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_bubble.cc:60: // Record UMA
for when the bubble is re-shown.
Comment won't be needed when method renamed.

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h
(right):

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h:70: void
BubbleReshown();
Rename RecordBubbleReshownUMA. Remove first comment line.

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h:72: void
Exiting();
RecordExitingUMA

https://codereview.chromium.org/1721633002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1721633002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:11538: +    a session of fullscreen mode
(not including mouse lock). If the mouse is
I don't think " (not including mouse lock)" is needed.

https://codereview.chromium.org/1721633002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:11539: +    also locked while a re-show
occurs, counts for both this and
When the mouse is also locked during a re-show both this and
BubbleReshowsPerSession.Mouselock are incremented.

https://codereview.chromium.org/1721633002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:11550: +    a session of mouse lock
mode. If also in fullscreen while a re-show occurs,
ditto

[Ilya Sherman, 2016-02-24 01:08:20]

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc
(right):

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc:86:
UMA_HISTOGRAM_COUNTS_100(histogram_name, bubble_reshow_count_);
The UMA_HISTOGRAM_* macros require that histogram names be runtime constants, so
you'll need one macro invocation per histogram name.  (Or, you could skip the
macro and call the underlying C++ functions directly.)

https://codereview.chromium.org/1721633002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1721633002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:11538: +    a session of fullscreen mode
(not including mouse lock). If the mouse is
Optional nit: I'd write "during a session" rather than "in a session" for a bit
of extra clarity.

[Matt Giuca, 2016-02-24 03:00:31]

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/exclusive_access_bubble.cc (right):

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_bubble.cc:60: // Record UMA
for when the bubble is re-shown.
On 2016/02/23 23:52:26, scheib wrote:
> Comment won't be needed when method renamed.

Done.

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc
(right):

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc:86:
UMA_HISTOGRAM_COUNTS_100(histogram_name, bubble_reshow_count_);
On 2016/02/24 01:08:20, Ilya Sherman wrote:
> The UMA_HISTOGRAM_* macros require that histogram names be runtime constants,
so
> you'll need one macro invocation per histogram name.

They do? I could do that but I'm not sure why it's necessary. (Is it for
technical reasons, or a "rule" you have?)

UMA_HISTOGRAM_COUNTS_100 calls UMA_HISTOGRAM_CUSTOM_COUNTS, which uses name
twice:

1. name is passed to STATIC_HISTOGRAM_POINTER_BLOCK which passes it to
HISTOGRAM_POINTER_USE which passes it to HistogramBase::CheckName, which expects
a const StringPiece&.
2. name is passed to base::Histogram::FactoryGet which expects a const
std::string&.

In both cases, passing a non-constant std::string is fine.

So do I have to change it?

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h
(right):

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h:70: void
BubbleReshown();
On 2016/02/23 23:52:26, scheib wrote:
> Rename RecordBubbleReshownUMA. Remove first comment line.

Done.

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h:72: void
Exiting();
On 2016/02/23 23:52:26, scheib wrote:
> RecordExitingUMA

Done.

https://codereview.chromium.org/1721633002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1721633002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:11538: +    a session of fullscreen mode
(not including mouse lock). If the mouse is
On 2016/02/23 23:52:26, scheib wrote:
> I don't think " (not including mouse lock)" is needed.

I put that because "fullscreen" internally refers to fullscreen + mouselock
about 50% if the time. I think it's helpful.

https://codereview.chromium.org/1721633002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:11538: +    a session of fullscreen mode
(not including mouse lock). If the mouse is
On 2016/02/24 01:08:20, Ilya Sherman wrote:
> Optional nit: I'd write "during a session" rather than "in a session" for a
bit
> of extra clarity.

Done.

https://codereview.chromium.org/1721633002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:11539: +    also locked while a re-show
occurs, counts for both this and
On 2016/02/23 23:52:26, scheib wrote:
> When the mouse is also locked during a re-show both this and
> BubbleReshowsPerSession.Mouselock are incremented.

Done.

https://codereview.chromium.org/1721633002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:11550: +    a session of mouse lock
mode. If also in fullscreen while a re-show occurs,
On 2016/02/23 23:52:26, scheib wrote:
> ditto

Done.

[Matt Giuca, 2016-02-24 04:01:01]

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc
(right):

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc:86:
UMA_HISTOGRAM_COUNTS_100(histogram_name, bubble_reshow_count_);
On 2016/02/24 03:00:31, Matt Giuca wrote:
> On 2016/02/24 01:08:20, Ilya Sherman wrote:
> > The UMA_HISTOGRAM_* macros require that histogram names be runtime
constants,
> so
> > you'll need one macro invocation per histogram name.
> 
> They do? I could do that but I'm not sure why it's necessary. (Is it for
> technical reasons, or a "rule" you have?)
> 
> UMA_HISTOGRAM_COUNTS_100 calls UMA_HISTOGRAM_CUSTOM_COUNTS, which uses name
> twice:
> 
> 1. name is passed to STATIC_HISTOGRAM_POINTER_BLOCK which passes it to
> HISTOGRAM_POINTER_USE which passes it to HistogramBase::CheckName, which
expects
> a const StringPiece&.
> 2. name is passed to base::Histogram::FactoryGet which expects a const
> std::string&.
> 
> In both cases, passing a non-constant std::string is fine.
> 
> So do I have to change it?

Oh right... I just hit the DCHECK in HistogramBase::CheckName. (Not sure why I
didn't hit it in my previous testing.) Now I get it; it specifically ensures
that you don't change the name string between instances of the same static call
to UMA_HISTOGRAM_* so that it can optimize.

(This isn't really documented... there is a huge block of text in
histogram_macros.h about how this static checking works, but I just assumed it
was implementation details. There is no documentation on the UMA_HISTOGRAM_*
macros themselves that say "name must be a compile-time constant"; maybe all of
those "name" parameters should just be renamed to "constant_name" to drive the
point home?)

I moved the call to UMA_HISTOGRAM_COUNTS_100 into each subclass (with a constant
string). A bit of duplication, but the alternative is to use a switch statement
over the type of subclass, which is nasty. And I don't want to thwart the
optimization by directly calling the function.

[Ilya Sherman, 2016-02-24 06:42:34]

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc
(right):

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc:86:
UMA_HISTOGRAM_COUNTS_100(histogram_name, bubble_reshow_count_);
On 2016/02/24 04:01:00, Matt Giuca wrote:
> On 2016/02/24 03:00:31, Matt Giuca wrote:
> > On 2016/02/24 01:08:20, Ilya Sherman wrote:
> > > The UMA_HISTOGRAM_* macros require that histogram names be runtime
> constants,
> > so
> > > you'll need one macro invocation per histogram name.
> > 
> > They do? I could do that but I'm not sure why it's necessary. (Is it for
> > technical reasons, or a "rule" you have?)
> > 
> > UMA_HISTOGRAM_COUNTS_100 calls UMA_HISTOGRAM_CUSTOM_COUNTS, which uses name
> > twice:
> > 
> > 1. name is passed to STATIC_HISTOGRAM_POINTER_BLOCK which passes it to
> > HISTOGRAM_POINTER_USE which passes it to HistogramBase::CheckName, which
> expects
> > a const StringPiece&.
> > 2. name is passed to base::Histogram::FactoryGet which expects a const
> > std::string&.
> > 
> > In both cases, passing a non-constant std::string is fine.
> > 
> > So do I have to change it?
> 
> Oh right... I just hit the DCHECK in HistogramBase::CheckName. (Not sure why I
> didn't hit it in my previous testing.) Now I get it; it specifically ensures
> that you don't change the name string between instances of the same static
call
> to UMA_HISTOGRAM_* so that it can optimize.
> 
> (This isn't really documented... there is a huge block of text in
> histogram_macros.h about how this static checking works, but I just assumed it
> was implementation details. There is no documentation on the UMA_HISTOGRAM_*
> macros themselves that say "name must be a compile-time constant"; maybe all
of
> those "name" parameters should just be renamed to "constant_name" to drive the
> point home?)
> 
> I moved the call to UMA_HISTOGRAM_COUNTS_100 into each subclass (with a
constant
> string). A bit of duplication, but the alternative is to use a switch
statement
> over the type of subclass, which is nasty. And I don't want to thwart the
> optimization by directly calling the function.

Yeah, it is definitely a rather epic comment.  I agree that it would be nice to
somehow make this point clearer, though I'm not sure that changing the variable
names in the macro to constant_name would be all that much clearer.  Documenting
each macro might be.

FWIW, the optimization only really matters in tight loops -- you probably don't
really need it for this code.  But, LGTM either way.

[Matt Giuca, 2016-02-25 04:27:08]

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc
(right):

https://codereview.chromium.org/1721633002/diff/60001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc:86:
UMA_HISTOGRAM_COUNTS_100(histogram_name, bubble_reshow_count_);
On 2016/02/24 06:42:34, Ilya Sherman wrote:
> On 2016/02/24 04:01:00, Matt Giuca wrote:
> > On 2016/02/24 03:00:31, Matt Giuca wrote:
> > > On 2016/02/24 01:08:20, Ilya Sherman wrote:
> > > > The UMA_HISTOGRAM_* macros require that histogram names be runtime
> > constants,
> > > so
> > > > you'll need one macro invocation per histogram name.
> > > 
> > > They do? I could do that but I'm not sure why it's necessary. (Is it for
> > > technical reasons, or a "rule" you have?)
> > > 
> > > UMA_HISTOGRAM_COUNTS_100 calls UMA_HISTOGRAM_CUSTOM_COUNTS, which uses
name
> > > twice:
> > > 
> > > 1. name is passed to STATIC_HISTOGRAM_POINTER_BLOCK which passes it to
> > > HISTOGRAM_POINTER_USE which passes it to HistogramBase::CheckName, which
> > expects
> > > a const StringPiece&.
> > > 2. name is passed to base::Histogram::FactoryGet which expects a const
> > > std::string&.
> > > 
> > > In both cases, passing a non-constant std::string is fine.
> > > 
> > > So do I have to change it?
> > 
> > Oh right... I just hit the DCHECK in HistogramBase::CheckName. (Not sure why
I
> > didn't hit it in my previous testing.) Now I get it; it specifically ensures
> > that you don't change the name string between instances of the same static
> call
> > to UMA_HISTOGRAM_* so that it can optimize.
> > 
> > (This isn't really documented... there is a huge block of text in
> > histogram_macros.h about how this static checking works, but I just assumed
it
> > was implementation details. There is no documentation on the UMA_HISTOGRAM_*
> > macros themselves that say "name must be a compile-time constant"; maybe all
> of
> > those "name" parameters should just be renamed to "constant_name" to drive
the
> > point home?)
> > 
> > I moved the call to UMA_HISTOGRAM_COUNTS_100 into each subclass (with a
> constant
> > string). A bit of duplication, but the alternative is to use a switch
> statement
> > over the type of subclass, which is nasty. And I don't want to thwart the
> > optimization by directly calling the function.
> 
> Yeah, it is definitely a rather epic comment.  I agree that it would be nice
to
> somehow make this point clearer, though I'm not sure that changing the
variable
> names in the macro to constant_name would be all that much clearer. 
Documenting
> each macro might be.
> 
> FWIW, the optimization only really matters in tight loops -- you probably
don't
> really need it for this code.  But, LGTM either way.

I'd rather use the macro than manually inlining it (regardless of optimization).
Otherwise I feel like I'm digging into the implementation details which may
break.

[Matt Giuca, 2016-02-25 04:27:29]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-02-25 04:27:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1721633002/#ps100001
(title: "Moved histogram recording into each subclass. (Fix DCHECK / incorrect
histogram recording.)")

[commit-bot: I haz the power, 2016-02-25 04:28:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1721633002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1721633002/100001

[commit-bot: I haz the power, 2016-02-25 05:49:47]

Description was changed from

==========
Added UMA collection for fullscreen / mouse lock bubble re-shows.

During a fullscreen / mouse lock session, it collects data about the
total number of times the bubble is re-shown due to input timeout. At
the end of the session, it logs the count to UMA.

BUG=585354
==========

to

==========
Added UMA collection for fullscreen / mouse lock bubble re-shows.

During a fullscreen / mouse lock session, it collects data about the
total number of times the bubble is re-shown due to input timeout. At
the end of the session, it logs the count to UMA.

BUG=585354
==========

[commit-bot: I haz the power, 2016-02-25 05:49:48]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-25 05:51:30]

Description was changed from

==========
Added UMA collection for fullscreen / mouse lock bubble re-shows.

During a fullscreen / mouse lock session, it collects data about the
total number of times the bubble is re-shown due to input timeout. At
the end of the session, it logs the count to UMA.

BUG=585354
==========

to

==========
Added UMA collection for fullscreen / mouse lock bubble re-shows.

During a fullscreen / mouse lock session, it collects data about the
total number of times the bubble is re-shown due to input timeout. At
the end of the session, it logs the count to UMA.

BUG=585354

Committed: https://crrev.com/d1e6fe94b6268034c6f127f11f044ca949b4fdbf
Cr-Commit-Position: refs/heads/master@{#377516}
==========

[commit-bot: I haz the power, 2016-02-25 05:51:32]

Patchset 6 (id:??) landed as
https://crrev.com/d1e6fe94b6268034c6f127f11f044ca949b4fdbf
Cr-Commit-Position: refs/heads/master@{#377516}