Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: chrome/browser/ui/exclusive_access/fullscreen_controller.h

Issue 1721633002: Added UMA collection for fullscreen / mouse lock bubble re-shows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved histogram recording into each subclass. (Fix DCHECK / incorrect histogram recording.) Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_FULLSCREEN_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_FULLSCREEN_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_FULLSCREEN_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_FULLSCREEN_CONTROLLER_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 152
153 // Posts a task to call NotifyFullscreenChange. 153 // Posts a task to call NotifyFullscreenChange.
154 void PostFullscreenChangeNotification(bool is_fullscreen); 154 void PostFullscreenChangeNotification(bool is_fullscreen);
155 // Sends a NOTIFICATION_FULLSCREEN_CHANGED notification. 155 // Sends a NOTIFICATION_FULLSCREEN_CHANGED notification.
156 void NotifyFullscreenChange(bool is_fullscreen); 156 void NotifyFullscreenChange(bool is_fullscreen);
157 157
158 // Notifies the tab that it has been forced out of fullscreen mode if 158 // Notifies the tab that it has been forced out of fullscreen mode if
159 // necessary. 159 // necessary.
160 void NotifyTabExclusiveAccessLost() override; 160 void NotifyTabExclusiveAccessLost() override;
161 161
162 void RecordBubbleReshowsHistogram(int bubble_reshow_count) override;
163
162 void ToggleFullscreenModeInternal(FullscreenInternalOption option); 164 void ToggleFullscreenModeInternal(FullscreenInternalOption option);
163 void EnterFullscreenModeInternal(FullscreenInternalOption option); 165 void EnterFullscreenModeInternal(FullscreenInternalOption option);
164 void ExitFullscreenModeInternal(); 166 void ExitFullscreenModeInternal();
165 void SetFullscreenedTab(content::WebContents* tab, const GURL& origin); 167 void SetFullscreenedTab(content::WebContents* tab, const GURL& origin);
166 168
167 ContentSetting GetFullscreenSetting() const; 169 ContentSetting GetFullscreenSetting() const;
168 170
169 void SetPrivilegedFullscreenForTesting(bool is_privileged); 171 void SetPrivilegedFullscreenForTesting(bool is_privileged);
170 // Returns true if |web_contents| was toggled into/out of fullscreen mode as a 172 // Returns true if |web_contents| was toggled into/out of fullscreen mode as a
171 // screen-captured tab. See 'FullscreenWithinTab Note'. 173 // screen-captured tab. See 'FullscreenWithinTab Note'.
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 // Used in testing to confirm proper behavior for specific, privileged 213 // Used in testing to confirm proper behavior for specific, privileged
212 // fullscreen cases. 214 // fullscreen cases.
213 bool is_privileged_fullscreen_for_testing_; 215 bool is_privileged_fullscreen_for_testing_;
214 216
215 base::WeakPtrFactory<FullscreenController> ptr_factory_; 217 base::WeakPtrFactory<FullscreenController> ptr_factory_;
216 218
217 DISALLOW_COPY_AND_ASSIGN(FullscreenController); 219 DISALLOW_COPY_AND_ASSIGN(FullscreenController);
218 }; 220 };
219 221
220 #endif // CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_FULLSCREEN_CONTROLLER_H_ 222 #endif // CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_FULLSCREEN_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698