Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1721053002: Change return value of ObjectStore::PreallocateObjects to return the error object or null instead o… (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change return value of ObjectStore::PreallocateObjects to return the error object or null instead of a bool. Most of the times the sticky error is cleared and returned as an error so returning a bool and querying the sticky error here does not work as the sticky error is a null object. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/2964f9e750448c14099251c065fe65abeff92169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M runtime/vm/dart.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/object_store.h View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/object_store.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 10 months ago (2016-02-22 20:15:45 UTC) #2
srdjan
lgtm
4 years, 10 months ago (2016-02-22 21:10:15 UTC) #3
siva
4 years, 10 months ago (2016-02-22 21:37:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2964f9e750448c14099251c065fe65abeff92169 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698