Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: runtime/vm/object_store.h

Issue 1721053002: Change return value of ObjectStore::PreallocateObjects to return the error object or null instead o… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/object_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_store.h
diff --git a/runtime/vm/object_store.h b/runtime/vm/object_store.h
index 2cab02ba46bdd3093ab4afb09cc572a87c91c54b..92be955561599b0c55c3689fe4305c23b3f32d5f 100644
--- a/runtime/vm/object_store.h
+++ b/runtime/vm/object_store.h
@@ -478,9 +478,9 @@ class ObjectStore {
void VisitObjectPointers(ObjectPointerVisitor* visitor);
// Called to initialize objects required by the vm but which invoke
- // dart code. If an error occurs then false is returned and error
- // information is stored in Thread::sticky_error().
- bool PreallocateObjects();
+ // dart code. If an error occurs the error object is returned otherwise
+ // a null object is returned.
+ RawError* PreallocateObjects();
void InitKnownObjects();
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/object_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698