Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: runtime/vm/dart.cc

Issue 1721053002: Change return value of ObjectStore::PreallocateObjects to return the error object or null instead o… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart.cc
diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc
index e3ba4a46f6ff3adf3618b0039a9c026caddafe04..895d6b192b5e6fa137818d574c2d3db8b8532fe7 100644
--- a/runtime/vm/dart.cc
+++ b/runtime/vm/dart.cc
@@ -464,8 +464,9 @@ RawError* Dart::InitializeIsolate(const uint8_t* snapshot_buffer, void* data) {
I->set_ic_miss_code(miss_code);
if (snapshot_buffer == NULL) {
- if (!I->object_store()->PreallocateObjects()) {
- return T->sticky_error();
+ const Error& error = Error::Handle(I->object_store()->PreallocateObjects());
+ if (!error.IsNull()) {
+ return error.raw();
}
}
« no previous file with comments | « no previous file | runtime/vm/object_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698