Add ContextRec param to SkShader::contextSize()

Add ContextRec param to SkShader::contextSize()

To facilitate upcoming context selection changes.

R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720933002

Committed: https://skia.googlesource.com/skia/+/8d9f2e474ac9d175c28079357b022d31408e2fe4

[f(malita), 2016-02-22 15:58:27]

Description was changed from

==========
Additional info for 4f shader context selection

Add more info to SkShader::ContextRec to support 4b-vs-4f shader context
selection.

Also plumb ContextRec in SkShader::contextSize().

R=reed@google.com,mtklein@google.com,herb@google.com
==========

to

==========
Additional info for 4f shader context selection

Add more info to SkShader::ContextRec to support 4b-vs-4f shader context
selection.

Also plumb ContextRec in SkShader::contextSize().

R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[f(malita), 2016-02-22 16:09:50]

https://codereview.chromium.org/1720933002/diff/1/include/core/SkShader.h
File include/core/SkShader.h (right):

https://codereview.chromium.org/1720933002/diff/1/include/core/SkShader.h#new...
include/core/SkShader.h:112: const SkColorProfileType fDeviceColorProfile;
I'm kinda torn on pushing explicit dst color info to the shaders - it means
they'll likely end up duplicating some of SkBlitter's heuristics in deciding
whether to optimize for 4b or 4f.

SkBlitter should know which shadeSpan method is going to use, so maybe a more
assertive

bool fWillCallShadeSpan4f;

would provide less footgun?

[f(malita), 2016-02-22 16:09:59]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 16:10:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1720933002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1720933002/1

[commit-bot: I haz the power, 2016-02-22 16:36:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 16:36:40]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-02-22 17:08:23]

https://codereview.chromium.org/1720933002/diff/1/include/core/SkShader.h
File include/core/SkShader.h (right):

https://codereview.chromium.org/1720933002/diff/1/include/core/SkShader.h#new...
include/core/SkShader.h:112: const SkColorProfileType fDeviceColorProfile;
On 2016/02/22 16:09:50, f(malita) wrote:
> I'm kinda torn on pushing explicit dst color info to the shaders - it means
> they'll likely end up duplicating some of SkBlitter's heuristics in deciding
> whether to optimize for 4b or 4f.
> 
> SkBlitter should know which shadeSpan method is going to use, so maybe a more
> assertive
> 
> bool fWillCallShadeSpan4f;
> 
> would provide less footgun?

PS#2 implements this alternative approach, replacing the color info with a
preferred-dst-type computed in SkBlitter.

PTAL

[f(malita), 2016-02-22 17:08:32]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 17:08:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1720933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1720933002/20001

[commit-bot: I haz the power, 2016-02-22 17:23:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 17:23:46]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[f(malita), 2016-02-22 17:44:22]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 17:44:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1720933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1720933002/40001

[f(malita), 2016-02-22 18:08:47]

Description was changed from

==========
Additional info for 4f shader context selection

Add more info to SkShader::ContextRec to support 4b-vs-4f shader context
selection.

Also plumb ContextRec in SkShader::contextSize().

R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add ContextRec param to SkShader::contextSize

To facilitate upcoming context selection changes.

R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[f(malita), 2016-02-22 18:10:45]

Mike suggested this would be easier to review if we land the contextSize(const
ContextRec&) plumbing separately.  Updated to do that.

[f(malita), 2016-02-22 18:10:50]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 18:10:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1720933002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1720933002/60001

[reed1, 2016-02-22 18:13:38]

lgtm

[f(malita), 2016-02-22 18:19:05]

Description was changed from

==========
Add ContextRec param to SkShader::contextSize

To facilitate upcoming context selection changes.

R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add ContextRec param to SkShader::contextSize()

To facilitate upcoming context selection changes.

R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[f(malita), 2016-02-22 18:19:20]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2016-02-22 18:19:24]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-02-22 18:19:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1720933002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1720933002/60001

[commit-bot: I haz the power, 2016-02-22 18:39:44]

Description was changed from

==========
Add ContextRec param to SkShader::contextSize()

To facilitate upcoming context selection changes.

R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add ContextRec param to SkShader::contextSize()

To facilitate upcoming context selection changes.

R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8d9f2e474ac9d175c28079357b022d31408e2fe4
==========

[commit-bot: I haz the power, 2016-02-22 18:39:45]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8d9f2e474ac9d175c28079357b022d31408e2fe4