third_party/WebKit/Source/platform/graphics/Image.h - Issue 1720853002: Remove Image::computeIntrinsicDimensions()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/Image.h

Issue 1720853002: Remove Image::computeIntrinsicDimensions() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-and-use-updateconcretesize-upload

Patch Set: Avoid using the size of the error image. Null-check in ImageResource saved the day in previous patc… Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/GeneratedImage.h ('K') | « third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp ('k') | third_party/WebKit/Source/platform/graphics/Image.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/Image.h

diff --git a/third_party/WebKit/Source/platform/graphics/Image.h b/third_party/WebKit/Source/platform/graphics/Image.h

index 089832c197e5a14e75ae4d74942c02ab48900297..4d31e1de53c866d13678fd8ef4bd7c66c6e313ec 100644

--- a/third_party/WebKit/Source/platform/graphics/Image.h

+++ b/third_party/WebKit/Source/platform/graphics/Image.h

@@ -93,11 +93,6 @@ public:

virtual bool usesContainerSize() const { return false; }

virtual bool hasRelativeSize() const { return false; }

- // Computes (extracts) the intrinsic dimensions and ratio from the Image. The intrinsic ratio

- // will be the 'viewport' of the image. (Same as the dimensions for a raster image. For SVG

- // images it can be the dimensions defined by the 'viewBox'.)

- virtual void computeIntrinsicDimensions(FloatSize& intrinsicSize, FloatSize& intrinsicRatio);

virtual IntSize size() const = 0;

IntRect rect() const { return IntRect(IntPoint(), size()); }

int width() const { return size().width(); }