Remove Image::computeIntrinsicDimensions()

third_party/WebKit/Source/platform/graphics/GeneratedImage.h

Index: third_party/WebKit/Source/platform/graphics/GeneratedImage.h
diff --git a/third_party/WebKit/Source/platform/graphics/GeneratedImage.h b/third_party/WebKit/Source/platform/graphics/GeneratedImage.h
index 6409111c0e163ea1291aa9b9776688f286483829..de9cb3928af4b74331e7aa5c634d8286a58f6182 100644
--- a/third_party/WebKit/Source/platform/graphics/GeneratedImage.h
+++ b/third_party/WebKit/Source/platform/graphics/GeneratedImage.h
@@ -38,7 +38,6 @@ public:
 
     bool usesContainerSize() const override { return true; }
     bool hasRelativeSize() const override { return true; }
-    void computeIntrinsicDimensions(FloatSize& intrinsicSize, FloatSize& intrinsicRatio) override;

[Justin Novosad, 2016/03/08 21:56:35]

Why is intrinsicRatio a FloatSize rather than a float?

[davve, 2016/03/09 08:06:10]

I assume it is/was to delay actual computation of the ratio to actual use. I did
a similar thing in https://codereview.chromium.org/1690253002/ and the layout
test results showed only progressions.
Heh, yeah, the interface was confusing.

For SVG images the intrinsic size would be zero/empty for SVG lacking
width/height attributes or if any of them would be a percentage values. If the
SVG had the viewBox attribute, however, the intrinsic aspect ratio would be
derived from there. I.e <svg viewBox="0 0 1 1"/> would have empty intrinsic size
but 1:1 intrinsic aspect ratio. This in turn would affect the subsequent size
calculations.

Now all these details are hidden inside SVGImage::concreteObjectSize() enabling
us to remove this interface.

 
     IntSize size() const override { return m_size; }