third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp - Issue 1720853002: Remove Image::computeIntrinsicDimensions()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp

Issue 1720853002: Remove Image::computeIntrinsicDimensions() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-and-use-updateconcretesize-upload

Patch Set: Avoid using the size of the error image. Null-check in ImageResource saved the day in previous patc… Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/GeneratedImage.h ('K') | « third_party/WebKit/Source/platform/graphics/GeneratedImage.h ('k') | third_party/WebKit/Source/platform/graphics/Image.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp b/third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp

index 4d7ca669b77c181dacea7e7e056fb3a2766af40f..afe68b2419c1b73ab320a33ff569789c17523f26 100644

--- a/third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp

+++ b/third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp

@@ -37,12 +37,6 @@

namespace blink {

-void GeneratedImage::computeIntrinsicDimensions(FloatSize& intrinsicSize, FloatSize& intrinsicRatio)

- Image::computeIntrinsicDimensions(intrinsicSize, intrinsicRatio);

- intrinsicRatio = FloatSize();

void GeneratedImage::drawPattern(GraphicsContext& destContext, const FloatRect& srcRect, const FloatSize& scale,

const FloatPoint& phase, SkXfermode::Mode compositeOp, const FloatRect& destRect,

const FloatSize& repeatSpacing)