Remove Image::computeIntrinsicDimensions()

third_party/WebKit/Source/platform/graphics/GeneratedImage.h

 /*
  * Copyright (C) 2008 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 20 matching lines @@
 #include "wtf/RefPtr.h"
 
 namespace blink {
 
 class PLATFORM_EXPORT GeneratedImage : public Image {
 public:
     bool currentFrameHasSingleSecurityOrigin() const override { return true; }
 
     bool usesContainerSize() const override { return true; }
     bool hasRelativeSize() const override { return true; }
-    void computeIntrinsicDimensions(FloatSize& intrinsicSize, FloatSize& intrinsicRatio) override;

[Justin Novosad, 2016/03/08 21:56:35]

Why is intrinsicRatio a FloatSize rather than a float?

[davve, 2016/03/09 08:06:10]

I assume it is/was to delay actual computation of the ratio to actual use. I did
a similar thing in https://codereview.chromium.org/1690253002/ and the layout
test results showed only progressions.
Heh, yeah, the interface was confusing.

For SVG images the intrinsic size would be zero/empty for SVG lacking
width/height attributes or if any of them would be a percentage values. If the
SVG had the viewBox attribute, however, the intrinsic aspect ratio would be
derived from there. I.e <svg viewBox="0 0 1 1"/> would have empty intrinsic size
but 1:1 intrinsic aspect ratio. This in turn would affect the subsequent size
calculations.

Now all these details are hidden inside SVGImage::concreteObjectSize() enabling
us to remove this interface.

 
     IntSize size() const override { return m_size; }
 
     // Assume that generated content has no decoded data we need to worry about
     void destroyDecodedData(bool) override { }
 
     PassRefPtr<SkImage> imageForCurrentFrame() override;
 
 protected:
     void drawPattern(GraphicsContext&, const FloatRect&,
         const FloatSize&, const FloatPoint&, SkXfermode::Mode,
         const FloatRect&, const FloatSize& repeatSpacing) final;
 
     // FIXME: Implement this to be less conservative.
     bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override { return false; }
 
     GeneratedImage(const IntSize& size) : m_size(size) { }
 
     virtual void drawTile(GraphicsContext&, const FloatRect&) = 0;
 
     IntSize m_size;
 };
 
 } // namespace blink
 
 #endif