Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 1720063002: Spec-compliant shorthand parsing of foo-break-(after,before,inside). (Closed)

Created:
4 years, 10 months ago by mstensho (USE GERRIT)
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Spec-compliant shorthand parsing of foo-break-(after,before,inside). The CL that introduced the generic break-after, break-before and break-inside properties deliberately violated the spec when it came to parsing the page-break-(after,before,inside) shorthand properties. This was in order to reduce the risk of a big revert, and instead remain as compatible as we could with how we used to handle it prior to the introduction of the new generic properties, i.e. when we parsed and stored separate properties for page-break-foo and -webkit-column-break-foo, rather than treating them as shorthands for break-foo. BUG=223068 Committed: https://crrev.com/1e723e74e19e48596466bb2357197dc6836d9c8a Cr-Commit-Position: refs/heads/master@{#376896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -65 lines) Patch
M third_party/WebKit/LayoutTests/fragmentation/break-properties.html View 2 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fragmentation/break-properties-expected.txt View 9 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 3 chunks +5 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 10 months ago (2016-02-22 21:11:15 UTC) #2
Timothy Loh
On 2016/02/22 21:11:15, mstensho wrote: lgtm
4 years, 10 months ago (2016-02-22 23:40:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720063002/1
4 years, 10 months ago (2016-02-23 01:40:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 01:48:34 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 01:49:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e723e74e19e48596466bb2357197dc6836d9c8a
Cr-Commit-Position: refs/heads/master@{#376896}

Powered by Google App Engine
This is Rietveld 408576698