Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1720063002: Spec-compliant shorthand parsing of foo-break-(after,before,inside). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Zack Rusin <zack@kde.org> 2 * Copyright (C) 2004 Zack Rusin <zack@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2011 Sencha, Inc. All rights reserved. 6 * Copyright (C) 2011 Sencha, Inc. All rights reserved.
7 * Copyright (C) 2015 Google Inc. All rights reserved. 7 * Copyright (C) 2015 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Lesser General Public 10 * modify it under the terms of the GNU Lesser General Public
(...skipping 1313 matching lines...) Expand 10 before | Expand all | Expand 10 after
1324 } 1324 }
1325 1325
1326 static EBreak mapToPageBreakValue(EBreak genericBreakValue) 1326 static EBreak mapToPageBreakValue(EBreak genericBreakValue)
1327 { 1327 {
1328 switch (genericBreakValue) { 1328 switch (genericBreakValue) {
1329 case BreakAvoidColumn: 1329 case BreakAvoidColumn:
1330 case BreakColumn: 1330 case BreakColumn:
1331 case BreakRecto: 1331 case BreakRecto:
1332 case BreakVerso: 1332 case BreakVerso:
1333 return BreakAuto; 1333 return BreakAuto;
1334 case BreakLeft:
1335 case BreakRight:
1336 // TODO(mstensho): "left" and "right" should simply be mapped to that, n ot "always", according to spec.
1337 case BreakPage: 1334 case BreakPage:
1338 return BreakAlways; 1335 return BreakAlways;
1339 case BreakAvoidPage: 1336 case BreakAvoidPage:
1340 return BreakAvoid; 1337 return BreakAvoid;
1341 default: 1338 default:
1342 return genericBreakValue; 1339 return genericBreakValue;
1343 } 1340 }
1344 } 1341 }
1345 1342
1346 static EBreak mapToColumnBreakValue(EBreak genericBreakValue) 1343 static EBreak mapToColumnBreakValue(EBreak genericBreakValue)
(...skipping 1406 matching lines...) Expand 10 before | Expand all | Expand 10 after
2753 case CSSPropertyAll: 2750 case CSSPropertyAll:
2754 return nullptr; 2751 return nullptr;
2755 default: 2752 default:
2756 break; 2753 break;
2757 } 2754 }
2758 ASSERT_NOT_REACHED(); 2755 ASSERT_NOT_REACHED();
2759 return nullptr; 2756 return nullptr;
2760 } 2757 }
2761 2758
2762 } // namespace blink 2759 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698