third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 1720063002: Spec-compliant shorthand parsing of foo-break-(after,before,inside).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1720063002: Spec-compliant shorthand parsing of foo-break-(after,before,inside). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fragmentation/break-properties-expected.txt ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 4566ed639956caa1ca4aeb02849b6c18cbbab74d..19da7afb077d7826c3fba488e08a0ac4a019bbe8 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -1331,9 +1331,6 @@ static EBreak mapToPageBreakValue(EBreak genericBreakValue)

case BreakRecto:

case BreakVerso:

return BreakAuto;

- case BreakLeft:

- case BreakRight:

- // TODO(mstensho): "left" and "right" should simply be mapped to that, not "always", according to spec.

case BreakPage:

return BreakAlways;

case BreakAvoidPage: