Remove foo != NULL outside of xfa/

Remove foo != NULL outside of xfa/

Most of these are from the XFA branch.

R=dsinclair@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/5eca305b1586b2107566a5c124baa5f2e00096c0

[Lei Zhang, 2016-02-23 03:14:40]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-02-23 03:28:32]

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
File core/src/fxcodec/codec/fx_codec_progress.cpp (left):

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:1014: if (m_pSrcBuf == NULL) {
Do we assume the allocation can't fail?

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:1931: m_pFile = NULL;
Does m_pFile not need to be reset?

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:2000: m_pFile = NULL;
ditto

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:2025: m_pFile = NULL;
ditto

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:2062: m_pFile = NULL;
ditto

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:2133: m_pFile = NULL;
ditto

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
File core/src/fxcodec/codec/fx_codec_progress.cpp (right):

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:384: if (pDIBitmap) {
Isn't this wrong? It was == NULL before, and now you've made it != NULL?

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:385: ASSERT(false);
nil: This is a lot less descriptive if it fails then the original was.

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/lbmp/fx_bm...
File core/src/fxcodec/lbmp/fx_bmp.cpp (right):

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/lbmp/fx_bm...
core/src/fxcodec/lbmp/fx_bmp.cpp:217: FX_Free(bmp_ptr->out_row_buffer);
Just checking, but FX_Free will set the pointer to null?

[Lei Zhang, 2016-02-23 03:37:54]

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
File core/src/fxcodec/codec/fx_codec_progress.cpp (left):

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:1014: if (m_pSrcBuf == NULL) {
On 2016/02/23 03:28:32, dsinclair wrote:
> Do we assume the allocation can't fail?

Yes.

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:1931: m_pFile = NULL;
On 2016/02/23 03:28:32, dsinclair wrote:
> Does m_pFile not need to be reset?

This is an unreachable failure path.

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
File core/src/fxcodec/codec/fx_codec_progress.cpp (right):

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:384: if (pDIBitmap) {
On 2016/02/23 03:28:32, dsinclair wrote:
> Isn't this wrong? It was == NULL before, and now you've made it != NULL?

Whoops.

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:385: ASSERT(false);
On 2016/02/23 03:28:32, dsinclair wrote:
> nil: This is a lot less descriptive if it fails then the original was.

This is basically NOTREACHED(). In the original code, line 390 and 391 are
somewhat redundant.

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/lbmp/fx_bm...
File core/src/fxcodec/lbmp/fx_bmp.cpp (right):

https://codereview.chromium.org/1720043003/diff/1/core/src/fxcodec/lbmp/fx_bm...
core/src/fxcodec/lbmp/fx_bmp.cpp:217: FX_Free(bmp_ptr->out_row_buffer);
On 2016/02/23 03:28:32, dsinclair wrote:
> Just checking, but FX_Free will set the pointer to null?

No, but we immediately reassign the pointer on the next line.

[dsinclair, 2016-02-23 03:42:34]

lgtm

[Lei Zhang, 2016-02-23 04:30:45]

https://codereview.chromium.org/1720043003/diff/20001/core/src/fxcodec/codec/...
File core/src/fxcodec/codec/fx_codec_progress.cpp (right):

https://codereview.chromium.org/1720043003/diff/20001/core/src/fxcodec/codec/...
core/src/fxcodec/codec/fx_codec_progress.cpp:529: ASSERT(p);
And auto-complete fail. Maybe I forgot to do a debug build.

[Lei Zhang, 2016-02-23 04:34:39]

Description was changed from

==========
Remove foo != NULL outside of xfa/

Most of these are from the XFA branch.
==========

to

==========
Remove foo != NULL outside of xfa/

Most of these are from the XFA branch.

R=dsinclair@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/5eca305b1586b2107566a5c124baa5f2e000...
==========

[Lei Zhang, 2016-02-23 04:34:40]

Committed patchset #4 (id:60001) manually as
5eca305b1586b2107566a5c124baa5f2e00096c0 (presubmit successful).