Remove foo != NULL outside of xfa/

fpdfsdk/src/formfiller/FFL_IFormFiller.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/include/formfiller/FFL_IFormFiller.h"
 
 #include "fpdfsdk/include/formfiller/FFL_CheckBox.h"
 #include "fpdfsdk/include/formfiller/FFL_ComboBox.h"
@@ skipping 729 matching lines @@
     m_bNotifying = FALSE;
   }
 }
 
 #ifdef PDF_ENABLE_XFA
 void CFFL_IFormFiller::OnClick(CPDFSDK_Widget* pWidget,
                                CPDFSDK_PageView* pPageView,
                                FX_BOOL& bReset,
                                FX_BOOL& bExit,
                                FX_UINT nFlag) {
-  ASSERT(pWidget != NULL);
-
   if (!m_bNotifying) {
     if (pWidget->HasXFAAAction(PDFSDK_XFA_Click)) {
       m_bNotifying = TRUE;
       int nAge = pWidget->GetAppearanceAge();
       int nValueAge = pWidget->GetValueAge();
 
       PDFSDK_FieldAction fa;
       fa.bModifier = m_pApp->FFI_IsCTRLKeyDown(nFlag);
       fa.bShift = m_pApp->FFI_IsSHIFTKeyDown(nFlag);
 
@@ skipping 15 matching lines @@
       }
     }
   }
 }
 
 void CFFL_IFormFiller::OnFull(CPDFSDK_Widget* pWidget,
                               CPDFSDK_PageView* pPageView,
                               FX_BOOL& bReset,
                               FX_BOOL& bExit,
                               FX_UINT nFlag) {
-  ASSERT(pWidget != NULL);
-
   if (!m_bNotifying) {
     if (pWidget->HasXFAAAction(PDFSDK_XFA_Full)) {
       m_bNotifying = TRUE;
       int nAge = pWidget->GetAppearanceAge();
       int nValueAge = pWidget->GetValueAge();
 
       PDFSDK_FieldAction fa;
       fa.bModifier = m_pApp->FFI_IsCTRLKeyDown(nFlag);
       fa.bShift = m_pApp->FFI_IsSHIFTKeyDown(nFlag);
 
@@ skipping 13 matching lines @@
 
         bReset = TRUE;
       }
     }
   }
 }
 
 void CFFL_IFormFiller::OnPopupPreOpen(void* pPrivateData,
                                       FX_BOOL& bExit,
                                       FX_DWORD nFlag) {
-  ASSERT(pPrivateData != NULL);
   CFFL_PrivateData* pData = (CFFL_PrivateData*)pPrivateData;
-  ASSERT(pData->pWidget != NULL);
+  ASSERT(pData);
+  ASSERT(pData->pWidget);
 
   FX_BOOL bTempReset = FALSE;
   FX_BOOL bTempExit = FALSE;
   this->OnPreOpen(pData->pWidget, pData->pPageView, bTempReset, bTempExit,
                   nFlag);
 
   if (bTempReset || bTempExit) {
     bExit = TRUE;
   }
 }
 
 void CFFL_IFormFiller::OnPopupPostOpen(void* pPrivateData,
                                        FX_BOOL& bExit,
                                        FX_DWORD nFlag) {
-  ASSERT(pPrivateData != NULL);
   CFFL_PrivateData* pData = (CFFL_PrivateData*)pPrivateData;
-  ASSERT(pData->pWidget != NULL);
+  ASSERT(pData);
+  ASSERT(pData->pWidget);
 
   FX_BOOL bTempReset = FALSE;
   FX_BOOL bTempExit = FALSE;
   this->OnPostOpen(pData->pWidget, pData->pPageView, bTempReset, bTempExit,
                    nFlag);
 
   if (bTempReset || bTempExit) {
     bExit = TRUE;
   }
 }
 
 void CFFL_IFormFiller::OnPreOpen(CPDFSDK_Widget* pWidget,
                                  CPDFSDK_PageView* pPageView,
                                  FX_BOOL& bReset,
                                  FX_BOOL& bExit,
                                  FX_UINT nFlag) {
-  ASSERT(pWidget != NULL);
-
   if (!m_bNotifying) {
     if (pWidget->HasXFAAAction(PDFSDK_XFA_PreOpen)) {
       m_bNotifying = TRUE;
       int nAge = pWidget->GetAppearanceAge();
       int nValueAge = pWidget->GetValueAge();
 
       PDFSDK_FieldAction fa;
       fa.bModifier = m_pApp->FFI_IsCTRLKeyDown(nFlag);
       fa.bShift = m_pApp->FFI_IsSHIFTKeyDown(nFlag);
 
@@ skipping 15 matching lines @@
       }
     }
   }
 }
 
 void CFFL_IFormFiller::OnPostOpen(CPDFSDK_Widget* pWidget,
                                   CPDFSDK_PageView* pPageView,
                                   FX_BOOL& bReset,
                                   FX_BOOL& bExit,
                                   FX_UINT nFlag) {
-  ASSERT(pWidget != NULL);
-
   if (!m_bNotifying) {
     if (pWidget->HasXFAAAction(PDFSDK_XFA_PostOpen)) {
       m_bNotifying = TRUE;
       int nAge = pWidget->GetAppearanceAge();
       int nValueAge = pWidget->GetValueAge();
 
       PDFSDK_FieldAction fa;
       fa.bModifier = m_pApp->FFI_IsCTRLKeyDown(nFlag);
       fa.bShift = m_pApp->FFI_IsSHIFTKeyDown(nFlag);
 
@@ skipping 108 matching lines @@
           bExit = TRUE;
           m_bNotifying = FALSE;
           return;
         }
       }
 
       m_bNotifying = FALSE;
     }
   }
 }