core/src/fpdfdoc/doc_form.cpp - Issue 1720043003: Remove foo != NULL outside of xfa/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfdoc/doc_form.cpp

Issue 1720043003: Remove foo != NULL outside of xfa/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfdoc/doc_form.cpp

diff --git a/core/src/fpdfdoc/doc_form.cpp b/core/src/fpdfdoc/doc_form.cpp

index 9252e073e047c53ead4c333cbb9904cee2110fc7..f40f447a685fe6c7bc8505493127a50ccb0bdfc9 100644

--- a/core/src/fpdfdoc/doc_form.cpp

+++ b/core/src/fpdfdoc/doc_form.cpp

@@ -393,7 +393,7 @@ static FX_BOOL RetrieveStockFont(int iFontObject,

uint8_t charSet,

LOGFONTA& lf) {

HFONT hFont = (HFONT)::GetStockObject(iFontObject);

- if (hFont != NULL) {

+ if (hFont) {

memset(&lf, 0, sizeof(LOGFONTA));

int iRet = ::GetObject(hFont, sizeof(LOGFONTA), &lf);

if (iRet > 0 && (lf.lfCharSet == charSet || charSet == 255)) {

« no previous file with comments | « no previous file | core/src/fpdfdoc/doc_tagged.cpp » ('j') | no next file with comments »