Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1719083002: Fixing include guards, and presubmit. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixing include guards, and presubmit. This update fixes all include guards so cpplint build/header_guard completes without error. A presubmit check is added to make sure the guards stay clean. BUG=pdfium:65 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/22d6607d104d4cb8c5263c4d307b4ba1e4ff959e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -97 lines) Patch
M PRESUBMIT.py View 1 chunk +7 lines, -0 lines 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_page.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/include/fwl/adapter/fwl_sdadapterimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/lightwidget/tooltipctrl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fgas/src/fgas_base.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/foxitlib.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_caretimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_editimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_formproxyimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_listboximp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_monthcalendarimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_pictureboximp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_pushbuttonimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_scrollbarimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_spinbuttonimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_tooltipctrlimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fxmath_barcodeimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomon.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h View 2 chunks +3 lines, -3 lines 1 comment Download
M xfa/src/fxbarcode/datamatrix/BC_HighLevelEncoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode128Writer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode39Reader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode39Writer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Codeword.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRBitMatrixParser.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCodeWriter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderBitVector.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/common/fxfa_localevalue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_parser.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_script.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL. This fixes issues with the previous include guard CL and makes all the includes ...
4 years, 10 months ago (2016-02-22 15:34:09 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1719083002/diff/1/xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h File xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h (right): https://codereview.chromium.org/1719083002/diff/1/xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h#newcode7 xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h:7: #ifndef XFA_SRC_FXBARCODE_COMMON_REEDSOLOMON_BC_REEDSOLOMONGF256POLY_H_ nice.
4 years, 10 months ago (2016-02-22 16:52:02 UTC) #3
dsinclair
4 years, 10 months ago (2016-02-22 16:56:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
22d6607d104d4cb8c5263c4d307b4ba1e4ff959e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698