PRESUBMIT.py - Issue 1719083002: Fixing include guards, and presubmit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1719083002: Fixing include guards, and presubmit. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 1ad3a5ea3e3339ac60f85cb8323c128271c016bd..6f19e24a465267508d51978e286b662c047381cd 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -8,7 +8,14 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

for more details about the presubmit API built into depot_tools.

"""

+LINT_FILTERS = [

+ '-',

+ '+build/header_guard',

def CheckChangeOnUpload(input_api, output_api):

results = []

results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)

+ results += input_api.canned_checks.CheckChangeLintsClean(

+ input_api, output_api, None, LINT_FILTERS)

return results