PRESUBMIT.py - Issue 1719083002: Fixing include guards, and presubmit.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: PRESUBMIT.py

Issue 1719083002: Fixing include guards, and presubmit. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for pdfium.	5 """Presubmit script for pdfium.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into depot_tools.	8 for more details about the presubmit API built into depot_tools.

9 """	9 """

10	10

	11 LINT_FILTERS = [

	12 '-',

	13 '+build/header_guard',

	14 ]

	15

11 def CheckChangeOnUpload(input_api, output_api):	16 def CheckChangeOnUpload(input_api, output_api):

12 results = []	17 results = []

13 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)	18 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)

	19 results += input_api.canned_checks.CheckChangeLintsClean(

	20 input_api, output_api, None, LINT_FILTERS)

14 return results	21 return results

OLD	NEW