Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1718333002: Migrate blimp/* to net::IPAddress. (Closed)

Created:
4 years, 10 months ago by martijnc
Modified:
4 years, 10 months ago
CC:
anandc+watch-blimp_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, dtrainor+watch-blimp_chromium.org, eroman, kmarshall+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate blimp/* to net::IPAddress. BUG=496258 Committed: https://crrev.com/bb30e6e5e322c24fffcd12ce6498ece955c40bb8 Cr-Commit-Position: refs/heads/master@{#377653}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : comments eroman #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M blimp/engine/session/blimp_engine_session.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M blimp/net/tcp_transport_unittest.cc View 1 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
martijnc
Hi, can you review this patch? Thanks!
4 years, 10 months ago (2016-02-24 22:45:47 UTC) #3
David Trainor- moved to gerrit
lgtm
4 years, 10 months ago (2016-02-25 00:06:29 UTC) #4
eroman
lgtm https://codereview.chromium.org/1718333002/diff/20001/blimp/net/tcp_transport_unittest.cc File blimp/net/tcp_transport_unittest.cc (right): https://codereview.chromium.org/1718333002/diff/20001/blimp/net/tcp_transport_unittest.cc#newcode45 blimp/net/tcp_transport_unittest.cc:45: void ParseAddress(const std::string& ip_str, I suggest deleting this ...
4 years, 10 months ago (2016-02-25 00:20:42 UTC) #6
martijnc
https://codereview.chromium.org/1718333002/diff/20001/blimp/net/tcp_transport_unittest.cc File blimp/net/tcp_transport_unittest.cc (right): https://codereview.chromium.org/1718333002/diff/20001/blimp/net/tcp_transport_unittest.cc#newcode45 blimp/net/tcp_transport_unittest.cc:45: void ParseAddress(const std::string& ip_str, On 2016/02/25 at 00:20:41, eroman ...
4 years, 10 months ago (2016-02-25 19:38:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718333002/40001
4 years, 10 months ago (2016-02-25 19:42:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-25 20:17:34 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 20:19:54 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb30e6e5e322c24fffcd12ce6498ece955c40bb8
Cr-Commit-Position: refs/heads/master@{#377653}

Powered by Google App Engine
This is Rietveld 408576698