Migrate blimp/* to net::IPAddress.

blimp/net/tcp_transport_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "blimp/common/create_blimp_message.h"
 #include "blimp/common/proto/blimp_message.pb.h"
 #include "blimp/common/proto/protocol_control.pb.h"
 #include "blimp/net/blimp_connection.h"
 #include "blimp/net/tcp_client_transport.h"
 #include "blimp/net/tcp_engine_transport.h"
 #include "blimp/net/test_common.h"
 #include "net/base/address_list.h"
+#include "net/base/ip_address.h"
 #include "net/base/ip_endpoint.h"
 #include "net/base/net_errors.h"
 #include "net/base/test_completion_callback.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::_;
 using testing::SaveArg;
 
 namespace blimp {
 
 namespace {
 
 // Integration test for TCPEngineTransport and TCPClientTransport.
 class TCPTransportTest : public testing::Test {
  protected:
   TCPTransportTest() {
     net::IPEndPoint local_address;
     ParseAddress("127.0.0.1", 0, &local_address);
     engine_.reset(new TCPEngineTransport(local_address, nullptr));
   }
 
   net::AddressList GetLocalAddressList() const {
     net::IPEndPoint local_address;
     engine_->GetLocalAddressForTesting(&local_address);
     return net::AddressList(local_address);
   }
 
   void ParseAddress(const std::string& ip_str,

[eroman, 2016/02/25 00:20:41]

I suggest deleting this function, and instead replacing the one caller with:

IPAddress(127, 0, 0, 1)

[martijnc, 2016/02/25 19:38:54]

Done.

                     uint16_t port,
                     net::IPEndPoint* address) {
-    net::IPAddressNumber ip_number;
-    bool rv = net::ParseIPLiteralToNumber(ip_str, &ip_number);
+    net::IPAddress ip_address;
+    bool rv = ip_address.AssignFromIPLiteral(ip_str);
     if (!rv)
       return;
-    *address = net::IPEndPoint(ip_number, port);
+    *address = net::IPEndPoint(ip_address, port);
   }
 
   base::MessageLoopForIO message_loop_;
   scoped_ptr<TCPEngineTransport> engine_;
 };
 
 TEST_F(TCPTransportTest, Connect) {
   net::TestCompletionCallback accept_callback;
   engine_->Connect(accept_callback.callback());
 
@@ skipping 83 matching lines @@
   // Client sends the second message.
   net::TestCompletionCallback client_send_callback2;
   client_connnection->GetOutgoingMessageProcessor()->ProcessMessage(
       std::move(client_message2), client_send_callback2.callback());
   EXPECT_EQ(net::OK, client_send_callback2.WaitForResult());
 }
 
 }  // namespace
 
 }  // namespace blimp